Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent message delivery receipts for carbons and own #1378

Merged
merged 1 commit into from Dec 15, 2018

Conversation

@ChaosKid42
Copy link
Contributor

commented Dec 12, 2018

dwd discovered that receipts were being sent for carbons. This PR prevents it.

@dwd

dwd approved these changes Dec 12, 2018

Copy link

left a comment

Yeah, I didn't discover it, so much as look at the code and wonder if it could happen. I've not actually verified that it is happening.

Nevertheless, this looks good, and looks like it will generally improve code when other things are added (like XEP-0333 for example).

@jcbrand

This comment has been minimized.

Copy link
Member

commented Dec 12, 2018

@ChaosKid42: Would you mind adding a regression test for this?

@ChaosKid42

This comment has been minimized.

Copy link
Contributor Author

commented Dec 12, 2018

@jcbrand: Yes. Not sure if I'll manage to do it before the end of the week though.

@ChaosKid42 ChaosKid42 force-pushed the ChaosKid42:prevent_receipts_for_carbons branch from dcc7e07 to 020ef43 Dec 15, 2018

@ChaosKid42

This comment has been minimized.

Copy link
Contributor Author

commented Dec 15, 2018

@jcbrand Finished the regression tests.

@jcbrand jcbrand merged commit 216a684 into conversejs:master Dec 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jcbrand

This comment has been minimized.

Copy link
Member

commented Dec 15, 2018

@ChaosKid42: Thank you!

@jcbrand jcbrand added this to the 4.0.7 milestone Dec 15, 2018

@ChaosKid42 ChaosKid42 deleted the ChaosKid42:prevent_receipts_for_carbons branch Dec 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.