Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

muc moderator commands can be disabled selectively #1412

Conversation

@ChaosKid42
Copy link
Contributor

commented Jan 14, 2019

I'd like to be able to selectively disable some muc moderator commands.

@ChaosKid42 ChaosKid42 force-pushed the ChaosKid42:selectively_disable_muc_moderator_commands branch from 6f713c5 to 041b341 Jan 14, 2019

@ChaosKid42 ChaosKid42 force-pushed the ChaosKid42:selectively_disable_muc_moderator_commands branch from 041b341 to 2962a43 Jan 23, 2019

@ChaosKid42 ChaosKid42 requested a review from jcbrand Jan 28, 2019

@ChaosKid42 ChaosKid42 force-pushed the ChaosKid42:selectively_disable_muc_moderator_commands branch 2 times, most recently from bdda263 to 283a88e Jan 28, 2019

src/converse-muc-views.js Outdated Show resolved Hide resolved
src/converse-muc-views.js Outdated Show resolved Hide resolved

@ChaosKid42 ChaosKid42 force-pushed the ChaosKid42:selectively_disable_muc_moderator_commands branch from 283a88e to 4f42919 Jan 29, 2019

@ChaosKid42

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

@jcbrand: Thanks for your review. That was really helpful and easy to implement.

@jcbrand

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

Hi @ChaosKid42

Looking good. Just one more thing please, and that is a test for this usecase.

It should be fairly quick and easy to do, you can copy paste this test and then just pass in a value for muc_disable_moderator_commands and update the assertions.

The 3rd parameter of initConverseWithPromises takes the configuration object (that's usually passed to converse.initialize), so that's where you pass in the value.

Thanks!

@ChaosKid42 ChaosKid42 force-pushed the ChaosKid42:selectively_disable_muc_moderator_commands branch from 4f42919 to 5a5d57a Jan 29, 2019

@ChaosKid42

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

@jcbrand Done. Really quite easy to do.

@jcbrand jcbrand merged commit b667eae into conversejs:master Jan 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jcbrand

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

Thanks! :)

@ChaosKid42 ChaosKid42 deleted the ChaosKid42:selectively_disable_muc_moderator_commands branch Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.