Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resurrect muc_show_join_leave option #1422

Closed
wants to merge 1 commit into from

Conversation

@weiss
Copy link
Contributor

commented Jan 22, 2019

Re-add the muc_show_join_leave option. It got lost in commit 9528d81.

@licaon-kter

This comment has been minimized.

Copy link
Contributor

commented Jan 22, 2019

Fixing #1263 too I hope?!

Resurrect muc_show_join_leave option
The option got lost in commit 9528d81.

Fixes #1263

@weiss weiss force-pushed the weiss:muc-show-join-leave branch from 029dfe9 to 4f7045b Jan 22, 2019

@jcbrand

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

Thanks. The tests were failing because you also needed to declare muc_show_join_leave as a setting (see here). I've made the necessary change and rebased manually.

@jcbrand jcbrand closed this Jan 29, 2019

@weiss weiss deleted the weiss:muc-show-join-leave branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.