Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contact nickname when receive a roster push #1438

Closed

Conversation

@aberenguel
Copy link
Contributor

commented Feb 9, 2019

When we change the roster item name in the server, the client receives a roster push but does not update the respective contact.
This PR fix that.

@jcbrand

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

Thanks @aberenguel.

There is now a failing test due to your change, can you please update spec/protocol to fix the test?

You can put in a new value for name on line 273 and then check that value on line 297.

@jcbrand jcbrand force-pushed the conversejs:master branch from 9f401e9 to 3a2dab9 Feb 18, 2019

jcbrand added a commit that referenced this pull request Feb 18, 2019

@jcbrand jcbrand closed this Feb 18, 2019

@jcbrand

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

I've merged manually and fixed the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.