Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room auto config #1554

Closed
wants to merge 2 commits into from

Conversation

@supun19
Copy link
Contributor

commented May 3, 2019

Thanks for making a pull request to converse.js!

Before submitting your request, please make sure the following conditions are met:

  • Add a changelog entry for your change in CHANGES.md
  • When adding a configuration variable, please make sure to
    document it in docs/source/configuration.rst
  • Please add a test for your change. Tests can be run in the commandline
    with make check or you can run them in the browser by running make serve
    and then opening http://localhost:8000/tests.html.
supun19 added 2 commits May 3, 2019
Room Open with default config
when a room is opened with default configuration if it contains fileds with type='fixed' the configuration used to break
Room Open with default config
when a room is opened with default configuration if it contains fileds with type='fixed' the configuration used to break
jcbrand added a commit that referenced this pull request May 3, 2019
Updates #1554
Room auto-configuration broke if the config form contained fields with type `fixed`
@jcbrand

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Thank you for the PR @supun19.

I noticed that the code in general could be improved, so I've refactored it a bit and then added a fix similar to yours.

@jcbrand jcbrand closed this May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.