Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios mobile viewport #1572

Closed
wants to merge 7 commits into from

Conversation

@supun19
Copy link
Contributor

commented May 14, 2019

ios mobile viewport was lessthan 100vh so had to redefine vh units each time

Thanks for making a pull request to converse.js!

Before submitting your request, please make sure the following conditions are met:

  • Add a changelog entry for your change in CHANGES.md
  • When adding a configuration variable, please make sure to
    document it in docs/source/configuration.rst
  • Please add a test for your change. Tests can be run in the commandline
    with make check or you can run them in the browser by running make serve
    and then opening http://localhost:8000/tests.html.
ios mobile viewport
ios mobile viewport was lessthan 100vh so had to redefine vh units each time
sass/_chatbox.scss Outdated Show resolved Hide resolved
dev.html Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
supun19 added 2 commits May 14, 2019
iOS mobile viewport
ref #1572 iOS mobile viewport was less than 100vh so had to redefine vh units each time
src/converse-controlbox.js Outdated Show resolved Hide resolved
supun19 added 4 commits May 14, 2019
iOS View Port
dynamically view port detect on iOS
Revert "iOS View Port"
This reverts commit 8bb4847.
iOS View Port
dynamically view port detect on iOS

@jcbrand jcbrand closed this in e56a878 May 15, 2019

@jcbrand

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Thanks, merged locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.