New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include ELB in the stack if there are no ports defined. #19

Merged
merged 3 commits into from Sep 3, 2015

Conversation

Projects
None yet
2 participants
@imbriaco
Copy link
Contributor

imbriaco commented Sep 3, 2015

Addresses #17.

This will exclude balancer resources from the stack if the manifest is not empty and there are no ports. The "manifest is not empty" part is there so that we pre-initialize ELB at app create time since that can take a while. When the first push comes in with no ports configured, the stack should be updated to remove the balancer and the associated resources cleaned up.

imbriaco added some commits Sep 3, 2015

ddollar added a commit that referenced this pull request Sep 3, 2015

Merge pull request #19 from imbriaco/convox-app
---

Addresses #17.

This will exclude balancer resources from the stack if the manifest is not empty and there are no ports. The "manifest is not empty" part is there so that we pre-initialize ELB at app create time since that can take a while. When the first push comes in with no ports configured, the stack should be updated to remove the balancer and the associated resources cleaned up.

ddollar added a commit that referenced this pull request Sep 3, 2015

Merge pull request #19 from imbriaco/no-elb
Don't include ELB in the stack if there are no ports defined.

@ddollar ddollar merged commit 79a1f65 into convox-archive:master Sep 3, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ddollar

This comment has been minimized.

Copy link
Contributor

ddollar commented Sep 3, 2015

tested as 20150903210045-optional-elb

@imbriaco imbriaco deleted the imbriaco:no-elb branch Sep 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment