New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attached run #109

Merged
merged 2 commits into from Aug 27, 2015

Conversation

Projects
None yet
3 participants

ddollar and others added some commits Jul 7, 2015

@nzoschke

This comment has been minimized.

Copy link
Contributor Author

nzoschke commented Aug 27, 2015

Currently this does not handle terminal control characters well at all.

$ convox run --app worker --attach worker1 sh
/go/src/github.com/convox-examples/worker # ls -al
ls -al
total 28
drwxr-xr-x    3 root     root          4096 Aug 14 17:08 .
drwxr-xr-x    3 root     root          4096 Aug 14 17:08 ..
drwxr-xr-x    7 root     root          4096 Aug 14 17:08 .git
-rw-r--r--    1 root     root           215 Jul 18 20:09 Dockerfile
-rw-r--r--    1 root     root            23 Jul 18 20:09 Procfile
-rw-r--r--    1 root     root             0 Aug 14 15:10 Readme.md
-rw-r--r--    1 root     root            40 Aug 14 17:08 docker-compose.yml
-rw-r--r--    1 root     root           208 Aug 14 17:08 worker.go
/go/src/github.com/convox-examples/worker # ^[[A^[[D^[[C^[[A^[[B
/go/src/github.com/convox-examples/worker # ^D
^C
@bgentry

This comment has been minimized.

Copy link

bgentry commented Aug 27, 2015

@nzoschke how about exit status? is that preserved?

nzoschke pushed a commit that referenced this pull request Aug 27, 2015

Noah Zoschke

@nzoschke nzoschke merged commit 80b74b8 into master Aug 27, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@nzoschke

This comment has been minimized.

Copy link
Contributor Author

nzoschke commented Aug 27, 2015

@bgentry not yet but you better believe we'll get it working well this time :)

@bgentry

This comment has been minimized.

Copy link

bgentry commented Aug 27, 2015

you better believe we'll get it working well this time :)

8 years and counting 📆

@nzoschke nzoschke referenced this pull request Aug 28, 2015

Merged

Attached Runs #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment