New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Release Failed Webhook Messages #1965
Conversation
move comment
QA Checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
Complete the QA checklist before merge
Codecov Report
@@ Coverage Diff @@
## master #1965 +/- ##
==========================================
- Coverage 30.16% 30.15% -0.02%
==========================================
Files 140 140
Lines 13986 13995 +9
==========================================
+ Hits 4219 4220 +1
- Misses 9323 9331 +8
Partials 444 444
Continue to review full report at Codecov.
|
@MiguelMoll manual QA complete, please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fixes #1654 |
We are incorrectly sending release failed webhooks with a message that says
unable to wait for promotion: ResourceNotReady: exceeded 120 wait attempts
.Looking at the aws
Waiter
source code it returns an error when the stack is in an update failed state, we were not handling this properly and always outputting this error.This PR
message": "release RYSPOEAUOVY failed - [AWS::ECS::Service:ServiceWeb] [UPDATE_FAILED]: Resource update cancelled",