New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for launching one-off processes #2970

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@ddollar
Member

ddollar commented Oct 5, 2018

No description provided.

ddollar added some commits Oct 5, 2018

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 5, 2018

Codecov Report

Merging #2970 into master will increase coverage by 0.02%.
The diff coverage is 2.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2970      +/-   ##
==========================================
+ Coverage   32.07%   32.09%   +0.02%     
==========================================
  Files         209      209              
  Lines       20155    20144      -11     
==========================================
+ Hits         6464     6465       +1     
+ Misses      12282    12270      -12     
  Partials     1409     1409
Impacted Files Coverage Δ
provider/local/process.go 6.49% <0%> (+0.32%) ⬆️
provider/aws/processes.go 46.27% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0010f6a...b4a786a. Read the comment docs.

codecov bot commented Oct 5, 2018

Codecov Report

Merging #2970 into master will increase coverage by 0.02%.
The diff coverage is 2.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2970      +/-   ##
==========================================
+ Coverage   32.07%   32.09%   +0.02%     
==========================================
  Files         209      209              
  Lines       20155    20144      -11     
==========================================
+ Hits         6464     6465       +1     
+ Misses      12282    12270      -12     
  Partials     1409     1409
Impacted Files Coverage Δ
provider/local/process.go 6.49% <0%> (+0.32%) ⬆️
provider/aws/processes.go 46.27% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0010f6a...b4a786a. Read the comment docs.

@ddollar ddollar added this to the 20181005 milestone Oct 5, 2018

ddollar added a commit that referenced this pull request Oct 5, 2018

@ddollar ddollar referenced this pull request Oct 5, 2018

Merged

[RELEASE] 20181005 #2971

15 of 15 tasks complete

@ddollar ddollar closed this in #2971 Oct 6, 2018

@ddollar ddollar deleted the oneoff branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment