New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] 20181007 #2973

Merged
merged 3 commits into from Oct 7, 2018

Conversation

Projects
None yet
1 participant
@ddollar
Member

ddollar commented Oct 7, 2018

Pull Requests

  • closes #2972 change vlan id for linux local rack to avoid conflict [@ddollar]

Milestone Release

  • Release branch
  • Pass CI
  • Merge into master
  • Close milestone
  • Release master
  • Record release number: 20181007171223
  • Pass CI
  • Update staging
  • Deploy staging/console-staging
  • Deploy staging/httpd
  • Deploy staging/site-staging
  • Write release notes
  • Documentation review
  • Publish release
  • Update Homebrew

ddollar added some commits Oct 7, 2018

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 7, 2018

Codecov Report

Merging #2973 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2973      +/-   ##
==========================================
+ Coverage   32.09%   32.09%   +<.01%     
==========================================
  Files         209      209              
  Lines       20149    20150       +1     
==========================================
+ Hits         6467     6468       +1     
  Misses      12273    12273              
  Partials     1409     1409
Impacted Files Coverage Δ
pkg/router/interface_linux.go 0% <0%> (ø) ⬆️
provider/local/system_linux.go 68.42% <100%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010208b...173bdbf. Read the comment docs.

codecov bot commented Oct 7, 2018

Codecov Report

Merging #2973 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2973      +/-   ##
==========================================
+ Coverage   32.09%   32.09%   +<.01%     
==========================================
  Files         209      209              
  Lines       20149    20150       +1     
==========================================
+ Hits         6467     6468       +1     
  Misses      12273    12273              
  Partials     1409     1409
Impacted Files Coverage Δ
pkg/router/interface_linux.go 0% <0%> (ø) ⬆️
provider/local/system_linux.go 68.42% <100%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010208b...173bdbf. Read the comment docs.

@ddollar ddollar merged commit d26e794 into master Oct 7, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 50% of diff hit (target 32.09%)
Details
codecov/project 32.09% (+<.01%) compared to 010208b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ddollar ddollar deleted the 20181007 branch Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment