New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] 20181010 #2978

Merged
merged 6 commits into from Oct 10, 2018

Conversation

Projects
None yet
1 participant
@ddollar
Member

ddollar commented Oct 10, 2018

Pull Requests

Milestone Release

  • Release branch
  • Pass CI
  • Merge into master
  • Close milestone
  • Release master
  • Record release number: 20181010180900
  • Pass CI
  • Update staging
  • Deploy staging/console-staging
  • Deploy staging/httpd
  • Deploy staging/site-staging
  • Write release notes
  • Documentation review
  • Publish release
  • Update Homebrew

ddollar added some commits Oct 8, 2018

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 10, 2018

Codecov Report

Merging #2978 into master will increase coverage by 0.09%.
The diff coverage is 70.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2978      +/-   ##
==========================================
+ Coverage   32.09%   32.19%   +0.09%     
==========================================
  Files         209      210       +1     
  Lines       20150    20206      +56     
==========================================
+ Hits         6468     6506      +38     
- Misses      12273    12284      +11     
- Partials     1409     1416       +7
Impacted Files Coverage Δ
provider/local/process_unix.go 0% <0%> (ø) ⬆️
pkg/cli/deploy.go 63.15% <100%> (ø) ⬆️
pkg/cli/cli.go 90% <100%> (+0.52%) ⬆️
pkg/cli/builds.go 74.45% <100%> (+0.28%) ⬆️
provider/local/system_linux.go 68.42% <100%> (ø) ⬆️
pkg/cli/test.go 70% <70%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d26e794...a6e08e5. Read the comment docs.

codecov bot commented Oct 10, 2018

Codecov Report

Merging #2978 into master will increase coverage by 0.09%.
The diff coverage is 70.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2978      +/-   ##
==========================================
+ Coverage   32.09%   32.19%   +0.09%     
==========================================
  Files         209      210       +1     
  Lines       20150    20206      +56     
==========================================
+ Hits         6468     6506      +38     
- Misses      12273    12284      +11     
- Partials     1409     1416       +7
Impacted Files Coverage Δ
provider/local/process_unix.go 0% <0%> (ø) ⬆️
pkg/cli/deploy.go 63.15% <100%> (ø) ⬆️
pkg/cli/cli.go 90% <100%> (+0.52%) ⬆️
pkg/cli/builds.go 74.45% <100%> (+0.28%) ⬆️
provider/local/system_linux.go 68.42% <100%> (ø) ⬆️
pkg/cli/test.go 70% <70%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d26e794...a6e08e5. Read the comment docs.

@ddollar ddollar merged commit 8cac66d into master Oct 10, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 70.49% of diff hit (target 32.09%)
Details
codecov/project 32.19% (+0.09%) compared to d26e794
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ddollar ddollar deleted the 20181010 branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment