New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support internal ports that are not exposed in the load balancer #48

Merged
merged 5 commits into from Sep 30, 2015

Conversation

Projects
None yet
3 participants
@ddollar
Copy link
Member

ddollar commented Sep 22, 2015

Defined without a colon like this:

ports:
  - 80:3000
  - 3001
@ddollar

This comment has been minimized.

Copy link
Member Author

ddollar commented Sep 22, 2015

/cc @imbriaco

@ddollar

This comment has been minimized.

Copy link
Member Author

ddollar commented Sep 22, 2015

@ddollar ddollar force-pushed the internal-ports branch from ecd74a4 to aeba5da Sep 22, 2015

@ddollar ddollar referenced this pull request Sep 23, 2015

Closed

Map ports w/o ELB #20

@imbriaco

This comment has been minimized.

Copy link
Contributor

imbriaco commented Sep 23, 2015

Awesome, thanks! If you cut a test release of this I'd be happy to update my staging rack to it as a trial run.

@ddollar ddollar force-pushed the internal-ports branch from e659ee8 to 219c8a5 Sep 23, 2015

@ddollar

This comment has been minimized.

Copy link
Member Author

ddollar commented Sep 23, 2015

20150923192531-internal-ports

@imbriaco

This comment has been minimized.

Copy link
Contributor

imbriaco commented Sep 23, 2015

Looking good!

ddollar added a commit that referenced this pull request Sep 30, 2015

Merge pull request #48 from convox/internal-ports
Support internal ports that are not exposed in the load balancer

@ddollar ddollar merged commit 0b9eec8 into master Sep 30, 2015

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.5%) to 60.795%
Details
@nzoschke

This comment has been minimized.

Copy link
Contributor

nzoschke commented Sep 30, 2015

👍

@ddollar ddollar deleted the internal-ports branch Sep 30, 2015

@imbriaco

This comment has been minimized.

Copy link
Contributor

imbriaco commented Sep 30, 2015

Woot! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment