Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use links to bind proxy container #648

Closed
wants to merge 4 commits into from
Closed

use links to bind proxy container #648

wants to merge 4 commits into from

Conversation

ddollar
Copy link
Contributor

@ddollar ddollar commented May 17, 2016

This allows the proxy container to connect to the container it's proxying for.

See also: convox/proxy#3

Quick CLI Release Playbook

  • Code review
  • Merge into master
  • Release CLI

@nzoschke
Copy link
Contributor

👍

@nzoschke
Copy link
Contributor

@mwarkentin
Copy link
Contributor

mwarkentin commented May 20, 2016

Actually, I might be seeing an issue - not sure if proxy related at this point. When I convox start with this branch, I'm able to make 1-2 requests to my app, and then requests just seem to hang there.

Wondering if there's an issue w/ proxy keeping a connection open that it's not supposed to or something, and exhausting my puma worker processes? Will try to debug further.

Edit: Looks like it might've been the URL that I was hitting.. sorry.

@ddollar
Copy link
Contributor Author

ddollar commented May 21, 2016

Merging on #668

@ddollar ddollar closed this May 21, 2016
@ddollar ddollar mentioned this pull request May 21, 2016
16 tasks
@ddollar ddollar deleted the proxy-link branch May 26, 2016 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants