New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch app name from .convox/app file if it exists #94

Merged
merged 2 commits into from Oct 14, 2015

Conversation

Projects
None yet
2 participants
@mattmanning
Copy link
Contributor

mattmanning commented Oct 13, 2015

With this change you can now set a .convox/app config file in your project containing the app name of the deployment. This way, you no longer have to include the --app option and your deployment name can differ from the current directory name.

App name detection now goes in this order, with the first found being used:

  • --app
  • .convox/app
  • current directory

Fixes #57

@mattmanning

This comment has been minimized.

Copy link
Contributor

mattmanning commented Oct 13, 2015

@ddollar

This comment has been minimized.

Copy link
Member

ddollar commented Oct 13, 2015

👍

@ddollar

This comment has been minimized.

Copy link
Member

ddollar commented Oct 13, 2015

This probably fails if you convox build ../some/other/dir but OK for now.

mattmanning added a commit that referenced this pull request Oct 14, 2015

Merge pull request #94 from convox/app-dotfile
fetch app name from .convox/app file if it exists

@mattmanning mattmanning merged commit 0ccdef4 into master Oct 14, 2015

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 60.506%
Details

@mattmanning mattmanning deleted the app-dotfile branch Oct 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment