Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: End of line detection and configuration. #1407

Merged
merged 18 commits into from May 28, 2020
Merged

Added: End of line detection and configuration. #1407

merged 18 commits into from May 28, 2020

Conversation

insspb
Copy link
Member

@insspb insspb commented May 27, 2020

This pull request is based on two old PRs #406 and #1159 and solve problem from issue #405

What changed:

After this PR merged cookiecutter will detect new-line symbol on each file in template and will use same new-line as in template, no matter on what system is deployed.

For template developers we introduce special key _new_lines that allow to force new line character on deployment. (check included docs).

This can break some old templates, that why marked as breaking change.

Some related tests refactored in style described in #1403 and #1405

@insspb insspb added windows This issue/PR related to windows systems only WIP Work In Progress feature This issue/PR relates to major feature request. labels May 27, 2020
@insspb insspb self-assigned this May 27, 2020
@insspb insspb changed the title Windows CRLF test Added: End of line detection and configuration. May 27, 2020
@insspb
Copy link
Member Author

insspb commented May 27, 2020

To do:

  • Force switcher
  • documentation.

Copy link
Contributor

@pombredanne pombredanne left a comment

Thank you for picking this up!

@insspb insspb force-pushed the win_crlf branch 2 times, most recently from 9aae5e9 to 8f1dc9e Compare May 27, 2020
@codeclimate
Copy link

codeclimate bot commented May 28, 2020

Code Climate has analyzed commit a34df66 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 99.7% (0.0% change).

View more on Code Climate.

@insspb insspb added breaking-change Marks an important and likely breaking change. Require update for major version and removed WIP Work In Progress labels May 28, 2020
@insspb insspb added this to the 2.0.0 milestone May 28, 2020
@ssbarnea ssbarnea merged commit 8a07cac into master May 28, 2020
2 checks passed
@ssbarnea ssbarnea deleted the win_crlf branch May 28, 2020
@simobasso simobasso mentioned this pull request May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Marks an important and likely breaking change. Require update for major version feature This issue/PR relates to major feature request. windows This issue/PR related to windows systems only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants