Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python version number in cookiecutter --version and test on Python 3.10 #1621

Merged

Conversation

ozer550
Copy link
Contributor

@ozer550 ozer550 commented Dec 12, 2021

Closes #1619

  • On Python 3.10 cookiecutter --version now prints Python 3.10 instead of Python 3.1
  • Added test to verify this behavior
  • Added cross-platform Python 3.10 CI environments

ozer550 and others added 3 commits Dec 11, 2021
Co-authored-by: Sahil <sahilflash123@gmail.com>
Co-authored-by: Sahil <sahilflash123@gmail.com>
Co-authored-by: Sahil <sahilflash123@gmail.com>
Copy link
Member

@audreyfeldroy audreyfeldroy left a comment

We reviewed this together over screenshare and I think this looks good, but I welcome others to review this.

@gotmax23
Copy link

gotmax23 commented Dec 15, 2021

I thought f-strings were not supported on Python 2.7 and 3.5, which this project purports it supports. Am I missing something?

@michaeljoseph
Copy link
Collaborator

michaeljoseph commented Dec 16, 2021

@gotmax23 where did you find references to those legacy python versions?
We don't support them any longer (as you can see from the CI runs).

cookiecutter/cli.py Outdated Show resolved Hide resolved
@gotmax23
Copy link

gotmax23 commented Dec 16, 2021

@gotmax23 where did you find references to those legacy python versions? We don't support them any longer (as you can see from the CI runs).

It's listed in one of the shields.io badges in the README. I guess that whatever data source it pulls from is outdated.

ozer550 and others added 3 commits Dec 18, 2021
Co-authored-by: Sahil <sahilflash123@gmail.com>
Co-authored-by: Sahil <sahilflash123@gmail.com>
Co-authored-by: Sahil <sahilflash123@gmail.com>
Copy link
Collaborator

@michaeljoseph michaeljoseph left a comment

🙌

@michaeljoseph michaeljoseph added the bug This issue/PR relates to a bug. label Dec 18, 2021
@michaeljoseph michaeljoseph merged commit 3ece249 into cookiecutter:master Dec 18, 2021
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cookiecutter --version prints out the wrong Python version on 3.10
4 participants