Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_generate_file_verbose_template_syntax_error fixed #1671

Merged
merged 3 commits into from May 29, 2022

Conversation

MaciejPatro
Copy link
Contributor

@MaciejPatro MaciejPatro commented May 7, 2022

Fixes #1655 - relative path that comes directly from Jinja2 TemplateSyntaxError
in some cases is in format "./tests/..." in other "tests/... now both cases
are accepted as a valid outcome.

Fixes cookiecutter#1655 - relative path that comes directly from Jinja2 TemplateSyntaxError
in some cases is in format "./tests/..." in other "tests/... now both cases
are accepted as a valid outcome.
att14
att14 approved these changes May 7, 2022
tests/test_generate_file.py Outdated Show resolved Hide resolved
Co-authored-by: jurgenwigg <53076001+jurgenwigg@users.noreply.github.com>
Copy link
Contributor

@jurgenwigg jurgenwigg left a comment

Please also fix lint issues.

@MaciejPatro
Copy link
Contributor Author

MaciejPatro commented May 16, 2022

In general the lint problem was unconnected with the tests - it was in the end problem with old version of black tool https://stackoverflow.com/questions/71673404/importerror-cannot-import-name-unicodefun-from-click . I didn't want to mix those things together - but if this helps you - it's fixed.

@jurgenwigg
Copy link
Contributor

jurgenwigg commented May 16, 2022

Green CI is always good idea :) Thanks for fixing CI

Copy link
Contributor

@jurgenwigg jurgenwigg left a comment

Nice fix :)

@MaciejPatro
Copy link
Contributor Author

MaciejPatro commented May 16, 2022

Glad I could help - thank you for the review :) - it's helpful.

@jensens jensens merged commit 69cd155 into cookiecutter:master May 29, 2022
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_generate_file_verbose_template_syntax_error fails with ./ difference in path
4 participants