Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spike] Test against rails4 with appraisal #30

Closed
wants to merge 8 commits into from

Conversation

sanemat
Copy link
Contributor

@sanemat sanemat commented Apr 17, 2013

THIS IS SPIKE

  • Add appraisal gem
  • Ignore generated gemfile.lock
  • Test against rails4.0
  • Add activeresorce (rails4.0)
  • Add protected_attributes (strong parameter - rails4.0)
  • Test with generated gemfile for travis-ci

Still fail logger format

gem "sass-rails", ">= 4.0.0.beta", "< 5"
gem "protected_attributes"

gemspec :path=>"../"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put "\n" at the last of file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file generated by appraisal automatically, so I'll pull req to appraisal.

@r7kamura
Copy link
Contributor

For now, I'm not planning to support Rails 4.0.0 beta version.
I'll support Rails 4.0.0 after its release.

@sanemat
Copy link
Contributor Author

sanemat commented Apr 17, 2013

Thanks!

@sanemat sanemat closed this Apr 17, 2013
@sanemat
Copy link
Contributor Author

sanemat commented Apr 17, 2013

Memo:
Active support v4.0 changes log format?
activesupport changes logging format
rack/rack#363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants