New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support android gradle plugin 3.0+ #46

Merged
merged 1 commit into from Jul 18, 2017

Conversation

Projects
None yet
2 participants
@chibatching
Contributor

chibatching commented Jul 18, 2017

Issue

  • checkLicenses task failed with Android Gradle Plugin 3.0.0-alpha4 #44

Do

  • Add configuration matching regexp for api and implementation.
    • We should use api or implementation instead of compile in android gradle plugin 3.0+.
  • Copy configuration and setCanBeResolved(true) to resolve configuration.
@gfx

This comment has been minimized.

Collaborator

gfx commented Jul 18, 2017

👀

@gfx gfx merged commit 6177632 into cookpad:master Jul 18, 2017

1 check passed

default Build finished.
Details

@chibatching chibatching deleted the chibatching:support_gradle_4.0+ branch Aug 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment