Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maintenance status #80

Merged
merged 2 commits into from Feb 12, 2019
Merged

Update maintenance status #80

merged 2 commits into from Feb 12, 2019

Conversation

@sorah
Copy link
Member

sorah commented Feb 5, 2019

We've retired our RRRSpec cluster. 馃憢

cc @draftcode

@sorah sorah requested a review from cookpad/rrrspec Feb 5, 2019
Copy link
Contributor

mame left a comment

nitpicking

README.md Outdated
@@ -10,6 +10,12 @@ RRRSpec is used in production as a CI service, running 60+ RSpec processes
concurrently, and it undergoes those failures, which include lots of `rb_bug`s,
assertion errors, and segmentation faults.

## MAINTENANCE NOTICE

As of Feb 2019, we, Cookpad, are not using RRRSpec internally. We may ocassionaly review and accept PRs, but note that this software is not under active maintainance.

This comment has been minimized.

Copy link
@mame

mame Feb 5, 2019

Contributor

nit: occasionally

README.md Outdated

As of Feb 2019, we, Cookpad, are not using RRRSpec internally. We may ocassionaly review and accept PRs, but note that this software is not under active maintainance.

(Background: The circumstances has been changed since 2013. Modern IaaS providers such as AWS now provides a machine with many vCPUs under the cheap pricing. Also, Cookpad is working to split their largest Rails monolith application ([blog post :jp:](https://techlife.cookpad.com/entry/2018-odaiba-strategy)). Thus, we decided to stop operating RRRSpec cluster.)

This comment has been minimized.

Copy link
@mame

mame Feb 5, 2019

Contributor

nit: provides -> provide

This comment has been minimized.

Copy link
@osyoyu

osyoyu Feb 5, 2019

Member

the cheap pricing -> cheap pricing (remove the the)

This comment has been minimized.

Copy link
@osyoyu

osyoyu Feb 5, 2019

Member

a machine -> machines

@draftcode

This comment has been minimized.

Copy link
Collaborator

draftcode commented Feb 5, 2019

LGTM

@sorah sorah merged commit e7d70bc into master Feb 12, 2019
@sorah sorah deleted the maint branch Feb 12, 2019
@yasaichi

This comment has been minimized.

Copy link
Contributor

yasaichi commented Feb 18, 2019

@sorah
Would you release the changes from v0.4.4 as v0.4.5 in future? because I'd like to apply this patch to my application.

P.S. Thanks for your development of these awesome gems until now!

@sorah

This comment has been minimized.

Copy link
Member Author

sorah commented Feb 22, 2019

@yasaichi Oops, I forgot about that. Pushed v0.4.5 just now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can鈥檛 perform that action at this time.