Add Windows support, allow braces in HTML #7

Merged
merged 4 commits into from Jun 2, 2013

Conversation

Projects
None yet
2 participants
@SLaks
Contributor

SLaks commented May 26, 2013

I fixed an issue with backslashes in URLs; this now works on Windows.

I also added Liquid {% raw %} tags around imported HTML so that it doesn't choke on HTML that looks like Liquid inclusions.

SLaks added some commits May 26, 2013

Fix paths on Windows
Convert backslashes from filenames to forward slahses for permalinks
Wrap imported HTML in Liquid {% raw %} tags
Fixes posts that have Liquid-like markup
Add opts.skipComments to ignore comments
This option is not yet exposed on the command
line; you'll need to manually add the option to
the b2j.parse() call in blogger2jekyll.js.

http://blog.slaks.net/2013-05-31/migrating-from-blogger-to-jekyll/
@SLaks

This comment has been minimized.

Show comment
Hide comment
@coolaj86

This comment has been minimized.

Show comment
Hide comment
@coolaj86

coolaj86 Jun 1, 2013

Owner

Hey, thanks a lot.

Sorry for the delay. I didn't mean to ignore this, I've been moving and forgot about it.

Will you do me a favor and make wrapping in liquid raw tags one of the options? maybe opts.liquidRaw?

Then I'll merge these all in and push the new version.

Owner

coolaj86 commented Jun 1, 2013

Hey, thanks a lot.

Sorry for the delay. I didn't mean to ignore this, I've been moving and forgot about it.

Will you do me a favor and make wrapping in liquid raw tags one of the options? maybe opts.liquidRaw?

Then I'll merge these all in and push the new version.

@SLaks

This comment has been minimized.

Show comment
Hide comment
@SLaks

SLaks Jun 2, 2013

Contributor

Done.

Ideally, it should also use commander or optimist to allow these options to be specified on the commandline, but I don't have time to add that.

Contributor

SLaks commented Jun 2, 2013

Done.

Ideally, it should also use commander or optimist to allow these options to be specified on the commandline, but I don't have time to add that.

coolaj86 added a commit that referenced this pull request Jun 2, 2013

Merge pull request #7 from SLaks/master
Add Windows support, allow braces in HTML

@coolaj86 coolaj86 merged commit 965d524 into coolaj86:master Jun 2, 2013

SLaks added a commit to SLaks/SLaks.Blog that referenced this pull request Jun 2, 2013

Update post: Migrating from Blogger to Jekyll
coolaj86/blogger2jekyll#7 has now been merged, but not published to npm.
@coolaj86

This comment has been minimized.

Show comment
Hide comment
@coolaj86

coolaj86 Jun 11, 2013

Owner

I published to npm, did I not?

Owner

coolaj86 commented Jun 11, 2013

I published to npm, did I not?

@coolaj86

This comment has been minimized.

Show comment
Hide comment
@coolaj86

coolaj86 Jun 11, 2013

Owner

Thanks for you work. :-D

Owner

coolaj86 commented Jun 11, 2013

Thanks for you work. :-D

@SLaks

This comment has been minimized.

Show comment
Hide comment
@SLaks

SLaks Jun 12, 2013

Contributor

I didn't see any change to package.json, so I assumed that you had not.

It looks like you ran npm publish --force to overwrite the existing version.
Can you bump the version (npm version minor will do that & commit it) and publish again?
This will allow people to pick up updates via npm.

Contributor

SLaks commented Jun 12, 2013

I didn't see any change to package.json, so I assumed that you had not.

It looks like you ran npm publish --force to overwrite the existing version.
Can you bump the version (npm version minor will do that & commit it) and publish again?
This will allow people to pick up updates via npm.

SLaks added a commit to SLaks/SLaks.Blog that referenced this pull request Jun 12, 2013

Update post: Migrating from Blogger to Jekyll
coolaj86/blogger2jekyll#7 has been pushed to npm.

I also forgot to fill in the next post link.
@coolaj86

This comment has been minimized.

Show comment
Hide comment
@coolaj86

coolaj86 Jun 12, 2013

Owner

Actually, I don't think I ever published the last time I got a pull request and it was still 1.0.0 until '1.3.0': '2013-06-02T22:19:23.377Z'

I'll rebump just in case, but I don't think I did --force

Owner

coolaj86 commented Jun 12, 2013

Actually, I don't think I ever published the last time I got a pull request and it was still 1.0.0 until '1.3.0': '2013-06-02T22:19:23.377Z'

I'll rebump just in case, but I don't think I did --force

@SLaks

This comment has been minimized.

Show comment
Hide comment
@SLaks

SLaks Jun 12, 2013

Contributor

I see; I had assumed that you published after 6c06e7c

Contributor

SLaks commented Jun 12, 2013

I see; I had assumed that you published after 6c06e7c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment