Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor position shifts when resizing #8

Closed
rygwdn opened this issue Feb 20, 2015 · 3 comments · Fixed by #13
Closed

Cursor position shifts when resizing #8

rygwdn opened this issue Feb 20, 2015 · 3 comments · Fixed by #13

Comments

@rygwdn
Copy link
Contributor

rygwdn commented Feb 20, 2015

This is pretty easy to reproduce. When I have the cursor near the right side of the window and then resize, I need to be very careful to resize the window such that the cursor remains lined up with the characters in the window, otherwise it moves off the character grid:

Working properly:
screen shot 2015-02-20 at 7 57 25 am

Resized horizontally:
screen shot 2015-02-20 at 7 57 44 am

The same issue happens vertically:
screen shot 2015-02-20 at 7 58 03 am
@coolwanglu
Copy link
Owner

After you resize the window (not during), did the font size become larger?
Ideally it should not, and the number of rows/cols should change accordingly.

@rygwdn
Copy link
Contributor Author

rygwdn commented Feb 20, 2015

the font size stays the same, but the spacing (both vertical and horizontal) changes.

rygwdn added a commit to rygwdn/neovim-e that referenced this issue Feb 21, 2015
@rygwdn
Give canvas tag an explicit size.
8212fcc 
Fixes coolwanglu#8

- Set the size in px of the canvas during resize. This avoids having the
  canvas stretch when the size of the window does not exactly line up
  with the expected size.
- When handling a resize, only change the size of the window if the
  window size doesn't match what is expected for the current number
  of rows/columns
- Fill the background of the window with the theme background color
@rygwdn rygwdn mentioned this issue Feb 21, 2015
Merged
@coolwanglu
Copy link
Owner

fixed via #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Give canvas tag an explicit size. rygwdn/neovim-e
2 participants
@rygwdn @coolwanglu