Remove N+1 from shared/_post view

[sauloperez]

The line below is responsible for a N+1:

timeoverflow/app/views/shared/_post.html.erb

Line 34 in 94a4ad8

<%= link_to post.member.display_name_with_uid, post.user %>

Due to:

timeoverflow/app/models/post.rb

Lines 122 to 124 in 94a4ad8

	def member
	@member ||= Member.find_by(user_id: user_id, organization_id: organization_id)
	end

That method is going introduce N+1 every time is used, as it is very likely that is going to be used as part of a larger query.

We should rely on eager loading the members association when needed instead.

[gpks]

I would love to try to fix this :)

[sauloperez]

Hi @gpks ! please go ahead. Keep in mind that the app has changed considerably recently so make sure you check the N+1 still exists first. Sorry for any inconvenience.

[enricostano]

@sauloperez can we close this issue? It seems that the N+1 is not there anymore. Right?

[sauloperez]

It seems so. Let's close it