Set default.locale to en #548
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauloperez
requested changes
Feb 17, 2020
|
@markets you might know what's going on |
…a submit button, not checking the language translation
|
👋 Taking a look in #401 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having problems with tests as much in local as in Travis because they weren't able to find the submit button on login, even though we were pretty sure of the button being there. At last, we found out that the page was printing in english and the test was looking for a spanish content of tag. So it wasn't able to find it.
In order of the test finding the submit button on login we set default.locale variable to english on
config/environments/test.rbto change the language in which the test looks for the button.It worked the other day in local, I have a witness (@sauloperez), but for some reason it's failing on Travis and local today. So, currently, I'm trying to figure out how to fix it for real.