From 761434e6262e2350e4cad546105f88f128981cfd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nicolas=20=C3=89vrard?= <nicoe@openhex.org>
Date: Tue, 16 Apr 2024 15:35:03 +0200
Subject: [PATCH 1/2] Add close button to "Filters" popup [CUSTOM]

Fix #CCOOG-642
---
 sao/src/sao.js              | 14 +++++++++++++-
 sao/src/screen.js           |  3 ++-
 sao/src/theme/coog/sao.less |  4 ++++
 3 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/sao/src/sao.js b/sao/src/sao.js
index d0119feae3f..516ecd9c8ba 100644
--- a/sao/src/sao.js
+++ b/sao/src/sao.js
@@ -939,7 +939,8 @@ var Sao = {
 
     Sao.Dialog = Sao.class_(Object, {
         init: function(
-            title, class_, size='sm', keyboard=true, small=null) {
+            title, class_, size='sm', keyboard=true, small=null,
+            closeable=false) {
             this.modal = jQuery('<div/>', {
                 'class': class_ + ' modal fade',
                 'role': 'dialog',
@@ -954,6 +955,17 @@ var Sao = {
             this.header = jQuery('<div/>', {
                 'class': 'modal-header'
             }).appendTo(this.content);
+            if (closeable) {
+                var close_button = jQuery('<button/>', {
+                    'type': 'button',
+                    'class': 'close',
+                    'data-dismiss': 'modal',
+                    'aria-label': Sao.i18n.gettext("Close"),
+                }).append(jQuery('<span>', {
+                    'aria-hidden': true,
+                }).append('&times;'));
+                this.header.append(close_button);
+            }
             if (title) {
                 this.add_title(title, small);
             }
diff --git a/sao/src/screen.js b/sao/src/screen.js
index f1a5922afac..6128c3b51b9 100644
--- a/sao/src/screen.js
+++ b/sao/src/screen.js
@@ -448,7 +448,8 @@
             };
             if (!this.search_modal) {
                 var dialog = new Sao.Dialog(
-                        Sao.i18n.gettext('Filters'), '', 'lg');
+                        Sao.i18n.gettext('Filters'), '', 'lg', true, null,
+                        true);
                 this.search_modal = dialog.modal;
                 this.search_form = dialog.content;
                 this.search_form.addClass('form-horizontal');
diff --git a/sao/src/theme/coog/sao.less b/sao/src/theme/coog/sao.less
index 2bd25c35f01..6d4055fdd82 100644
--- a/sao/src/theme/coog/sao.less
+++ b/sao/src/theme/coog/sao.less
@@ -477,6 +477,10 @@ div.modal-header {
     .coog-group-header-colors();
 }
 
+div.modal-header .close {
+    font-size: 21px;
+}
+
 div.wizard-dialog {
     // For "small" state views, bump the window width from 600px
     > div.modal-dialog.modal-md {

From 2ed74309b6f708aaf1e113d3b998ab5d7d824580 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nicolas=20=C3=89vrard?= <nicoe@openhex.org>
Date: Tue, 16 Apr 2024 18:34:48 +0200
Subject: [PATCH 2/2] Provide a button to close wizard windows if possible

---
 sao/src/wizard.js | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/sao/src/wizard.js b/sao/src/wizard.js
index bc6f5d08a52..6a5ac45d38a 100644
--- a/sao/src/wizard.js
+++ b/sao/src/wizard.js
@@ -190,6 +190,20 @@
             this.screen.add_view(view);
             this.screen.switch_view();
             this.screen.windows.push(this);
+            var close_button = jQuery('<button/>', {
+                'type': 'button',
+                'class': 'close',
+                'aria-label': Sao.i18n.gettext("Close"),
+            }).append(jQuery('<span>', {
+                'aria-hidden': true,
+            }).append('&times;'));
+            close_button.click((e) => {
+                e.preventDefault();
+                if (this.end_state in this.states) {
+                    this.response(this.states[this.end_state].attributes);
+                }
+            });
+            this.header.append(close_button);
             this.header.append(jQuery('<h4/>', {
                 'class': 'model-title',
                 'title': this.name,