Use absolute positioning for the expander span [CUSTOM] #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix PCLAS-1168 This is required because the column resizing sets a width on the col and the div inside the th which make the span tag stack. We can use absolute positioning inside the th because they're sticky and thus absolute will remove the span from the flow.
JCavallo
approved these changes
Oct 24, 2024
nicoe
added a commit
that referenced
this pull request
Oct 24, 2024
* Use absolute positioning for the expander span [CUSTOM] Fix PCLAS-1168 This is required because the column resizing sets a width on the col and the div inside the th which make the span tag stack. We can use absolute positioning inside the th because they're sticky and thus absolute will remove the span from the flow. * Iteration for style --------- Co-authored-by: Jean Cavallo <jean.cavallo@hotmail.fr>
nicoe
added a commit
that referenced
this pull request
Oct 24, 2024
…324) * Use absolute positioning for the expander span [CUSTOM] Fix PCLAS-1168 This is required because the column resizing sets a width on the col and the div inside the th which make the span tag stack. We can use absolute positioning inside the th because they're sticky and thus absolute will remove the span from the flow. * Iteration for style --------- Co-authored-by: Jean Cavallo <jean.cavallo@hotmail.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PCLAS-1168
This is required because the column resizing sets a width on the col and the div inside the th which make the span tag stack.
We can use absolute positioning inside the th because they're sticky and thus absolute will remove the span from the flow.