New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNOCKing is permitted on private channels #34

Closed
cooper opened this Issue Jun 24, 2016 · 7 comments

Comments

Projects
None yet
2 participants
@cooper
Owner

cooper commented Jun 24, 2016

add private channels in the form of a module Channel::Private, like Channel::Secret

@jlu5

This comment has been minimized.

jlu5 commented Jun 24, 2016

Honestly, RFC1459 +p is pretty useless nowadays compared to +s. AFAIK charybdis and derivatives don't even implement +p to be the RFC1459 "private" -- +p instead simply disables KNOCK to the channel.

@cooper

This comment has been minimized.

Owner

cooper commented Jun 24, 2016

I was planning to make it work the same as secret except for no knocking and that +p shows up in WHOIS whereas +s does not

@cooper

This comment has been minimized.

Owner

cooper commented Jun 24, 2016

RFC says to show them in LIST but show as "Prv." I will just see what charybdis does

@cooper

This comment has been minimized.

Owner

cooper commented Jun 24, 2016

from 2812:

   353    RPL_NAMREPLY
          "( "=" / "*" / "@" ) <channel>
           :[ "@" / "+" ] <nick> *( " " [ "@" / "+" ] <nick> )
     - "@" is used for secret channels, "*" for private
       channels, and "=" for others (public channels).

so that needs to be fixed for secret also

cooper added a commit that referenced this issue Jun 24, 2016

10.68: show_in_list also affected WHOIS, but now show_in_whois is sep…
…arate. this is necessary for adding private channel support, #34.             fixed incorrect name of numeric 353 RPL_NAMREPLY.             fixed warning caused by trying to unset away when not away.

cooper added a commit that referenced this issue Jun 25, 2016

10.73: NAMES without a parameter is currently not supported. instead …
…of sending ERR_NEEDMOREPARAMS, use RPL_LOAD2HI and RPL_ENDOFNAMES. fixed issue where show_in_whois was fired twice, each time with different arguments. added show_in_names which allows modules to hide users from NAMES. added names_character which allows modules to change the '=' char in NAMREPLYs. Channel::Secret now hides users in private or secret channels from NAMES. #34             Channel::Secret now appropriately sets the NAMREPLY character to '@' or '*' for secret and private channels respectively.
@cooper

This comment has been minimized.

Owner

cooper commented Jun 25, 2016

Private channels are now supported to the fullest extent which is currently possible. The functionality was added to the existing Channel::Secret module. Still need to prevent KNOCKing once that's implemented.

@cooper cooper changed the title from Add private channels to KNOCKing is permitted on private channels Jun 25, 2016

@cooper cooper removed the feature label Jun 25, 2016

@jlu5

This comment has been minimized.

jlu5 commented Jun 25, 2016

Other IRCds make noknock a separate mode (+K)

@cooper

This comment has been minimized.

Owner

cooper commented Jun 25, 2016

without the private/noknock behavior, +p is basically useless, so I'm gonna stick to the charybdis way

@cooper cooper closed this in 4ad8529 Jan 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment