New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code for joining channels is all over the place #76

Closed
cooper opened this Issue Jul 4, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@cooper
Copy link
Owner

cooper commented Jul 4, 2016

Core::UserCommands::cjoin(), Core::UserCommands::_cjoin(), channel::localjoin(), channel::cjoin(), the list goes on... Never know which one to use. The local join logic, which should work for both local and remote users, needs to be moved to channel.pm. It will check if the user is local; if so, send NAMES and MODE and other stuff. Then we can clean up SJOIN and JOIN handlers in TS6/JELP, simplify the client JOIN command, and get rid of some of these confusing methods. Also consider Forward.pm, which currently depends on Core::UserCommands and borrows _cjoin().

@cooper cooper added the internals label Jul 4, 2016

@cooper cooper closed this in fe1851a Jul 6, 2016

cooper added a commit that referenced this issue Jul 6, 2016

11.14: added IRCv3 extended-join support. added channel method ->send…
…from_all_cap(). updated JELP/TS6 SJOIN handlers to use new channel join methods. #76.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment