implement header_upstream directive for #4, docs

[erdii]

No description provided.

[coveralls]

Coverage increased (+0.6%) to 88.435% when pulling 32b2bca on feature/header-upstream into 75731c3 on master.

[erdii]

Hm.. for some strange reasons I cannot log into travis-ci.org and restart the failed pipeline. It failed with:

$ go get golang.org/x/tools/cmd/cover
package golang.org/x/tools/cmd/cover: unrecognized import path "golang.org/x/tools/cmd/cover" (https fetch: Get https://golang.org/x/tools/cmd/cover?go-get=1: net/http: TLS handshake timeout)
The command "go get golang.org/x/tools/cmd/cover" failed and exited with 1 during .

Since all other tests succeeded, I'll assume that a restart would indeed let the tests pass.

@coopernurse do you want to review the changes or can I merge?

[coopernurse]

Let's add a link to https://caddyserver.com/docs/placeholders in this doc section so folks know the valid set of placeholder variables.

It might also be nice to add an example that didn't use a placeholder, just to given an example of how that could be useful.

[coopernurse]

should replacer be defined outside the loop? I haven't read the docs on that type but I'm assuming we can safely call Replace() using the same instance inside the loop. Is that true?

[coopernurse]

Just a couple of little things, but overall looks good!

[coopernurse]

I'm not sure what's up with the travis build status. I restarted both jobs but I'm not seeing status reported here for some reason. I think when the above issues are addressed we can just merge it and see if it builds correctly from master.

[erdii]

Good points!

You're right, replacer should live outsive the loop in which it is used. Works exactly the same.
I also added a link to caddy's placeholder docs and a non-placeholder example.

Edit: but now the tests fail. I'm tired and will look into it tomorrow.

panic: interface conversion: interface is nil, not httpserver.Replacer [recovered]
	panic: interface conversion: interface is nil, not httpserver.Replacer

goroutine 16 [running]:
testing.tRunner.func1(0xc0001e7400)
	/usr/local/Cellar/go/1.11/libexec/src/testing/testing.go:792 +0x387
panic(0x16e6da0, 0xc0001ff800)
	/usr/local/Cellar/go/1.11/libexec/src/runtime/panic.go:513 +0x1b9
github.com/coopernurse/caddy-awslambda.(*Config).MaybeToInvokeInput(0xc000203ad0, 0xc0001e7500, 0x17a27ba, 0xd, 0x1)
	/Users/erdii/go/src/github.com/coopernurse/caddy-awslambda/config.go:161 +0x14f
github.com/coopernurse/caddy-awslambda.Handler.match(0x189a540, 0xc00020a4e0, 0xc00000e738, 0x1, 0x1, 0xc0001e7500, 0xc0001e4780, 0x40, 0x38, 0x1761720)
	/Users/erdii/go/src/github.com/coopernurse/caddy-awslambda/lambda.go:95 +0x11a
github.com/coopernurse/caddy-awslambda.Handler.ServeHTTP(0x189a540, 0xc00020a4e0, 0xc00000e738, 0x1, 0x1, 0x18a1c80, 0xc0001e4780, 0xc0001e7500, 0x0, 0x19afef8, ...)
	/Users/erdii/go/src/github.com/coopernurse/caddy-awslambda/lambda.go:28 +0x6d
github.com/coopernurse/caddy-awslambda.TestInvokeOK(0xc0001e7400)
	/Users/erdii/go/src/github.com/coopernurse/caddy-awslambda/lambda_test.go:28 +0x48b
testing.tRunner(0xc0001e7400, 0x17cbdc0)
	/usr/local/Cellar/go/1.11/libexec/src/testing/testing.go:827 +0xbf
created by testing.(*T).Run
	/usr/local/Cellar/go/1.11/libexec/src/testing/testing.go:878 +0x353
exit status 2
FAIL	github.com/coopernurse/caddy-awslambda	0.019s

[erdii]

Now it should be ok.
lambda_test.go .TestInvokeOK had to use a request with replacer context, too

Requested changes were incorporated

[erdii]

@coopernurse How do we request changes to https://caddyserver.com/docs/http.awslambda ?

[coopernurse]

@erdii Thanks for getting those changes in - it's merged now. Good question re: docs. I see mention of a developer portal now (fancy). I'll try to get in there and push an update.

[erdii]

Nice!

[coopernurse]

I was able to login and push an update. That kicked off a build somewhere and about 10 minutes later I got an email saying it worked.

However, this page still shows the old 2017 'last updated' date. https://caddyserver.com/docs/http.awslambda

So I'm not sure if there's anything else for us to do. Maybe the site docs only refresh daily? Let's keep an eye on it and see if it changes. But I think we're done.