New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process hangs with refreshIdle: false #148

Closed
olalonde opened this Issue Aug 2, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@olalonde

olalonde commented Aug 2, 2016

refreshIdle: false should prevent the remove timeout from being called, but it doesn't: https://github.com/coopernurse/node-pool/blob/master/lib/generic-pool.js#L243

@sandfox sandfox added the bug label Aug 10, 2016

@sandfox sandfox self-assigned this Aug 10, 2016

@sandfox sandfox added the confirmed label Aug 10, 2016

@sandfox sandfox added the v2.4 label Nov 6, 2016

@sandfox

This comment has been minimized.

Show comment
Hide comment
@sandfox

sandfox Nov 12, 2016

Collaborator

The documentation around refreshIdle (and it's name) is a little unclear. What it really means is "should I timeout resources which are part of the min pool size"
It doesn't turn off/on the general timeout behaviour - that is controlled by reapInterval and idleTimeoutMillis

Feel free to re-open this if you still something is broken.

Collaborator

sandfox commented Nov 12, 2016

The documentation around refreshIdle (and it's name) is a little unclear. What it really means is "should I timeout resources which are part of the min pool size"
It doesn't turn off/on the general timeout behaviour - that is controlled by reapInterval and idleTimeoutMillis

Feel free to re-open this if you still something is broken.

@sandfox sandfox closed this Nov 12, 2016

@sandfox sandfox removed the confirmed label Nov 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment