Global leak of 'err' and 'obj' in createResource #44

Closed
mlin opened this Issue Aug 9, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@mlin

mlin commented Aug 9, 2012

Please put 'var err, obj;' in the callback given to factory.create.

https://github.com/coopernurse/node-pool/blob/master/lib/generic-pool.js#L246

@coopernurse

This comment has been minimized.

Show comment Hide comment
@coopernurse

coopernurse Aug 24, 2012

Owner

Ok, that's been fixed in master. thanks!

Owner

coopernurse commented Aug 24, 2012

Ok, that's been fixed in master. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment