Skip to content

Conversation

@coordt
Copy link
Member

@coordt coordt commented Jan 4, 2023

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 4, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.86%.

Quality metrics Before After Change
Complexity 10.00 🙂 10.00 🙂 0.00
Method Length 95.00 🙂 104.50 🙂 9.50 👎
Working memory 10.00 😞 10.00 😞 0.00
Quality 52.90% 🙂 51.04% 🙂 -1.86% 👎
Other metrics Before After Change
Lines 58 60 2
Changed files Quality Before Quality After Quality Change
cookie_composer/merge_files/yaml_file.py 52.90% 🙂 51.04% 🙂 -1.86% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
cookie_composer/merge_files/yaml_file.py merge_yaml_files 10 🙂 172 😞 10 😞 51.04% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@coordt coordt merged commit 4b788d7 into master Jan 4, 2023
@coordt coordt deleted the yaml-formatting branch January 4, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants