Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to Debian packaging #333

Merged
merged 4 commits into from Jun 22, 2017

Conversation

@valholl
Copy link

commented Jan 5, 2017

While trying to build a deb I've found it had a number of issues including missing dependencies and a wrong version number,

This pull request fixes those and adds a few other trivial changes that fix some warnings.

It has been tested under both stretch (current testing) and jessie (current stable).

Please let me know if you need me to change anything

Elena Grandi added 3 commits Jan 3, 2017
Elena Grandi
Debian packaging: missing dependencies and new changelog entry
Signed-off-by: Elena Grandi <elena@truelite.it>
Elena Grandi
Updated compat and Standards-Version to current values
Signed-off-by: Elena Grandi <elena@truelite.it>
Elena Grandi
Removed conffiles that are already auto-selected as such
Signed-off-by: Elena Grandi <elena@truelite.it>
@sevan

This comment has been minimized.

Copy link
Member

commented Jan 6, 2017

Hi,
Thanks for the submission!
Where does the python & python-gtk dependency come from?

@valholl

This comment has been minimized.

Copy link
Author

commented Jan 9, 2017

@pinkra

This comment has been minimized.

Copy link
Member

commented Jan 12, 2017

yes, it should be optional..

@sevan

This comment has been minimized.

Copy link
Member

commented Jan 26, 2017

@valholl if the python & gtk dependencies aren't installed, what functionality do you lose in coova?

@valholl

This comment has been minimized.

Copy link
Author

commented Feb 2, 2017

@sevan Actually, I don't know: I was trying to build the deb package to install coova and try it out, and most of the contents of the PR came from the suggestions of some QA tools usually used in debian to check the debs (and I tried to select only the ones that are usually quite safe; there were others that may or may not be good suggestions that I skipped)

Elena Grandi
Turn python and python-gtk dependency into a Suggests
Signed-off-by: Elena Grandi <elena@truelite.it>
@valholl

This comment has been minimized.

Copy link
Author

commented Feb 2, 2017

I updated the PR to turn that dependency in a Suggests, since if I understand correctly those python files aren't really needed?

@pinkra
pinkra approved these changes Jun 22, 2017

@pinkra pinkra merged commit b9f477b into coova:master Jun 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.