Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for swig-4.1.0 macro definition correction #9

Merged
merged 1 commit into from Sep 14, 2022

Conversation

wsfulton
Copy link
Contributor

For swig-4.1.0 change:

    #2193 -DFOO on the SWIG command line now sets FOO to 1 for
    consistency with C/C++ compiler preprocessors.  Previously
    SWIG set FOO to an empty value.

See swig/swig#2193

This patch is backwards compatible with older versions of SWIG.

For swig-4.1.0 change:
    #2193 -DFOO on the SWIG command line now sets FOO to 1 for
    consistency with C/C++ compiler preprocessors.  Previously
    SWIG set FOO to an empty value.

See swig/swig#2193

This patch is backwards compatible with older versions of SWIG
@wsfulton
Copy link
Contributor Author

BTW, I can't see the point of these macros as I can't see them being used anywhere in the repository. Perhaps they should be removed altogether?

@fbergmann
Copy link
Member

@wsfulton these defines are necessary, when compiling against dependency libraries using C++ namespaces. So they cant be removed. I wonder whether the define should be set to =1 instead.

-DLIBSBML_CPP_NAMESPACE_USE=
-DLIBSBML_CPP_NAMESPACE_BEGIN=
-DLIBSBML_CPP_NAMESPACE_END=
-DLIBSEDML_CPP_NAMESPACE_USE==
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@fbergmann
Copy link
Member

i'll test in the morning against one of the namespaced libraries and let you know how things go

@fbergmann fbergmann merged commit 07d9e53 into copasi:develop Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants