Simplify XFCE desktop detection #52

Merged
merged 1 commit into from Feb 2, 2013

Projects

None yet

3 participants

@bogdan
Contributor
bogdan commented Sep 13, 2012

Current expression doesn't work on my machine by some reason.

$ xprop -root _DT_SAVE_MODE       
_DT_SAVE_MODE(STRING) = "xfce4"
$ xprop -root _DT_SAVE_MODE | grep ' = \"xfce\"$'       
$

I think we can use simpler expression to detect it that doesn't depend on grep and works for me.

@sferik
sferik commented Feb 2, 2013

👍

@copiousfreetime copiousfreetime merged commit 5aa595a into copiousfreetime:master Feb 2, 2013
@jsonn jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Feb 15, 2013
taca Update ruby-launchy to 2.2.0.
= Launchy Changlog
== Version 2.2.0 - 2013-02-06

* Change XFCE detection to not depend on grep (copiousfreetime/launchy#52 -
  thanks bogdan)
* Suppress forked process output (copiousfreetime/launchy#51)
* Display help/usage if no url is given (copiousfreetime/launchy#54)
* Detect the fluxbox environment (copiousfreetime/launchy#53)
* Automatically detect 'http' url's if they are missing the 'http://'
  (copiousfreetime/launchy#55)
* Update to latest project management rake tasks
9b74e30
@jperkin jperkin pushed a commit to joyent/pkgsrc that referenced this pull request Dec 9, 2013
taca Update ruby-launchy to 2.2.0.
= Launchy Changlog
== Version 2.2.0 - 2013-02-06

* Change XFCE detection to not depend on grep (copiousfreetime/launchy#52 -
  thanks bogdan)
* Suppress forked process output (copiousfreetime/launchy#51)
* Display help/usage if no url is given (copiousfreetime/launchy#54)
* Detect the fluxbox environment (copiousfreetime/launchy#53)
* Automatically detect 'http' url's if they are missing the 'http://'
  (copiousfreetime/launchy#55)
* Update to latest project management rake tasks
d7e7833
@jperkin jperkin pushed a commit to joyent/pkgsrc that referenced this pull request Mar 14, 2014
taca Update ruby-launchy to 2.2.0.
= Launchy Changlog
== Version 2.2.0 - 2013-02-06

* Change XFCE detection to not depend on grep (copiousfreetime/launchy#52 -
  thanks bogdan)
* Suppress forked process output (copiousfreetime/launchy#51)
* Display help/usage if no url is given (copiousfreetime/launchy#54)
* Detect the fluxbox environment (copiousfreetime/launchy#53)
* Automatically detect 'http' url's if they are missing the 'http://'
  (copiousfreetime/launchy#55)
* Update to latest project management rake tasks
f4ba8d4
@jsonn jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Oct 11, 2014
taca Update ruby-launchy to 2.2.0.
= Launchy Changlog
== Version 2.2.0 - 2013-02-06

* Change XFCE detection to not depend on grep (copiousfreetime/launchy#52 -
  thanks bogdan)
* Suppress forked process output (copiousfreetime/launchy#51)
* Display help/usage if no url is given (copiousfreetime/launchy#54)
* Detect the fluxbox environment (copiousfreetime/launchy#53)
* Automatically detect 'http' url's if they are missing the 'http://'
  (copiousfreetime/launchy#55)
* Update to latest project management rake tasks
1c1f2a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment