Select USB configuracion bug Nexus 5 #154

Closed
lagosazules opened this Issue Jan 29, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@lagosazules

I think I found a smal but importantant safety bug, in developer options - select USB Configuracion, if I select "Charging only" I have notice that after some time the setting changes always back to MTP.
Also when doing a reboot it change to MTP, I think having USB data access when this is not necessary is a extra safety risk.

@lagosazules lagosazules changed the title from C configuracion to Select USB configuracion bug Jan 29, 2016

@lagosazules lagosazules changed the title from Select USB configuracion bug to Select USB configuracion bug Nexus 5 Jan 29, 2016

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Jan 29, 2016

Contributor

The default is already charging only without touching anything in the developer settings. Those aren't user-facing settings and you aren't supposed to touch them for normal usage of the device, only debugging. I'm not sure what that option is supposed to do. It could be that it's obsolete. Regardless, it's an AOSP issue and doesn't appear to be a real security problem. I don't consider fixing AOSP bugs to be in-scope unless they have a direct security impact.

Contributor

thestinger commented Jan 29, 2016

The default is already charging only without touching anything in the developer settings. Those aren't user-facing settings and you aren't supposed to touch them for normal usage of the device, only debugging. I'm not sure what that option is supposed to do. It could be that it's obsolete. Regardless, it's an AOSP issue and doesn't appear to be a real security problem. I don't consider fixing AOSP bugs to be in-scope unless they have a direct security impact.

@thestinger thestinger closed this Jan 29, 2016

@lagosazules

This comment has been minimized.

Show comment Hide comment
@lagosazules

lagosazules Jan 29, 2016

Sorry but this is not correct, I have just checkt it again on build MMB29T.2016.01.28 and after a reboot it is back on MTB again

Sorry but this is not correct, I have just checkt it again on build MMB29T.2016.01.28 and after a reboot it is back on MTB again

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Jan 29, 2016

Contributor

The default is charge-only without touching anything in developer settings. Not sure what you've changed, but if you go back to the default state it will be using charge-only by default again. You shouldn't change it via developer settings because there's a user-facing menu to change the setting.

Contributor

thestinger commented Jan 29, 2016

The default is charge-only without touching anything in developer settings. Not sure what you've changed, but if you go back to the default state it will be using charge-only by default again. You shouldn't change it via developer settings because there's a user-facing menu to change the setting.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Jan 29, 2016

Contributor

The user-facing setting exposed via the notification menu works properly. The drop-down menu in developer settings seems like it wasn't properly updated for the changes in 6.0. The developer settings are only meant for debugging / development though - those features aren't necessarily robust and they shouldn't be used on a device that's meant to be secure, beyond turning off OEM unlocking again and then ideally disabling developer settings again. A phone with CopperheadOS pre-installed would have developer settings off by default, as that's the normal state.

Contributor

thestinger commented Jan 29, 2016

The user-facing setting exposed via the notification menu works properly. The drop-down menu in developer settings seems like it wasn't properly updated for the changes in 6.0. The developer settings are only meant for debugging / development though - those features aren't necessarily robust and they shouldn't be used on a device that's meant to be secure, beyond turning off OEM unlocking again and then ideally disabling developer settings again. A phone with CopperheadOS pre-installed would have developer settings off by default, as that's the normal state.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Jan 29, 2016

Contributor

See https://android.googlesource.com/platform/packages/apps/Settings.git/+/5eba30289a708d92f152d998c05bea3866316b3b. The way it works seems like it's intended. The default is effectively charge-only either way and developer settings being understandable only by the Android developers working on the OS is to be expected.

Contributor

thestinger commented Jan 29, 2016

See https://android.googlesource.com/platform/packages/apps/Settings.git/+/5eba30289a708d92f152d998c05bea3866316b3b. The way it works seems like it's intended. The default is effectively charge-only either way and developer settings being understandable only by the Android developers working on the OS is to be expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment