Download md5sums on OTA update #156

Closed
vanitasvitae opened this Issue Jan 30, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@vanitasvitae

Hi
When updating from twrp, it skips the md5sum check because no md5sum file has been found.

Would it make sense to ship the sum with the update? Or is the checksum checked somewhere else?

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Jan 30, 2016

Contributor

No, the updates are signed. The intention is that you use the official recovery image so that you have signature verification. Hashes won't provide any security.

Contributor

thestinger commented Jan 30, 2016

No, the updates are signed. The intention is that you use the official recovery image so that you have signature verification. Hashes won't provide any security.

@thestinger thestinger closed this Jan 30, 2016

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Jan 30, 2016

Contributor

The updater can verify the signature before it passes it to the recovery image but that's not as good as the recovery image doing it too.

Contributor

thestinger commented Jan 30, 2016

The updater can verify the signature before it passes it to the recovery image but that's not as good as the recovery image doing it too.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Jan 30, 2016

Contributor

Filed #158 about making sure that the Updater itself is doing signature verification. I already switched it to using a secure private download location, so an attacker would already need to exploit the Updater or have near root access to corrupt the download, but I expect that it's not properly verifying the signature - which is fine with the official recovery image, but it would be nice if it reported the error from the Updater app as that can be much friendlier to users than the recovery error handling.

Contributor

thestinger commented Jan 30, 2016

Filed #158 about making sure that the Updater itself is doing signature verification. I already switched it to using a secure private download location, so an attacker would already need to exploit the Updater or have near root access to corrupt the download, but I expect that it's not properly verifying the signature - which is fine with the official recovery image, but it would be nice if it reported the error from the Updater app as that can be much friendlier to users than the recovery error handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment