Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Download md5sums on OTA update #156
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Jan 30, 2016
Contributor
No, the updates are signed. The intention is that you use the official recovery image so that you have signature verification. Hashes won't provide any security.
|
No, the updates are signed. The intention is that you use the official recovery image so that you have signature verification. Hashes won't provide any security. |
thestinger
closed this
Jan 30, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Jan 30, 2016
Contributor
The updater can verify the signature before it passes it to the recovery image but that's not as good as the recovery image doing it too.
|
The updater can verify the signature before it passes it to the recovery image but that's not as good as the recovery image doing it too. |
thestinger
added
Type: enhancement
Status: wontfix
Type: question
labels
Jan 30, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Jan 30, 2016
Contributor
Filed #158 about making sure that the Updater itself is doing signature verification. I already switched it to using a secure private download location, so an attacker would already need to exploit the Updater or have near root access to corrupt the download, but I expect that it's not properly verifying the signature - which is fine with the official recovery image, but it would be nice if it reported the error from the Updater app as that can be much friendlier to users than the recovery error handling.
|
Filed #158 about making sure that the Updater itself is doing signature verification. I already switched it to using a secure private download location, so an attacker would already need to exploit the Updater or have near root access to corrupt the download, but I expect that it's not properly verifying the signature - which is fine with the official recovery image, but it would be nice if it reported the error from the Updater app as that can be much friendlier to users than the recovery error handling. |
vanitasvitae commentedJan 30, 2016
Hi
When updating from twrp, it skips the md5sum check because no md5sum file has been found.
Would it make sense to ship the sum with the update? Or is the checksum checked somewhere else?