Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Double free detection is causing some errors with Chrome #187
Comments
thestinger
added
the
Type: bug
label
Feb 18, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Feb 18, 2016
Contributor
Does it crash consistently or is this just an intermittent issue?
|
Does it crash consistently or is this just an intermittent issue? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Feb 18, 2016
Contributor
The error happens when an allocation is freed but there's no entry for the page in the region hash table. So it's a pointer to memory that's not currently handed out as a malloc allocation. It's one of the baseline OpenBSD malloc features rather than a CopperheadOS extension.
|
The error happens when an allocation is freed but there's no entry for the page in the region hash table. So it's a pointer to memory that's not currently handed out as a malloc allocation. It's one of the baseline OpenBSD malloc features rather than a CopperheadOS extension. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Feb 18, 2016
Contributor
So this might be a double-free, but it could also be free(invalid_ptr) where invalid_ptr was allocated with another allocator or something like that. It would be very helpful if you could provide tombstones. It would show whether the memory at that address is actually mapped and it might be labelled. Could add a debugging feature to OpenBSD malloc to label all the memory properly too - just didn't do that because it hits mmap quite a bit and adding the prctl call would add significant overhead.
|
So this might be a double-free, but it could also be |
thestinger
added
the
upstream-app
label
Feb 21, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Mar 11, 2016
Contributor
This needs to be reconfirmed with a new Chrome version and I don't think there's any way it's a CopperheadOS bug.
|
This needs to be reconfirmed with a new Chrome version and I don't think there's any way it's a CopperheadOS bug. |
Fuzion24 commentedFeb 18, 2016
https://gist.github.com/Fuzion24/1bac9d9eff0402d3796a