heartattack moments during first flash #294

Closed
anantshri opened this Issue Jun 2, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@anantshri

when a script gives out errors like

archive does not contain 'boot.sig'
archive does not contain 'recovery.sig'
archive does not contain 'system.sig'
archive does not contain 'vendor.sig' 

Might be a good idea to either hide those errors or ensure there is a message which confirms they are ignorable.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Jun 4, 2016

Contributor

I don't consider improving non-security-related upstream code to be in-scope. The stock factory images produce the same messages, and that's the experience I want to emulate. People can submit patches to AOSP if they want to improve Android in general, and those will be inherited by CopperheadOS.

Contributor

thestinger commented Jun 4, 2016

I don't consider improving non-security-related upstream code to be in-scope. The stock factory images produce the same messages, and that's the experience I want to emulate. People can submit patches to AOSP if they want to improve Android in general, and those will be inherited by CopperheadOS.

@thestinger thestinger closed this Jun 4, 2016

@anantshri

This comment has been minimized.

Show comment Hide comment
@anantshri

anantshri Jun 4, 2016

I would beg to differ on this. If my understanding of flashing scripts is right the messages are correct we are missing files. however that doesn't makes any difference for us. and hence it might be a good idea at our end to hide the error messages as its an unnecessary annoyance.

I would beg to differ on this. If my understanding of flashing scripts is right the messages are correct we are missing files. however that doesn't makes any difference for us. and hence it might be a good idea at our end to hide the error messages as its an unnecessary annoyance.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Jun 4, 2016

Contributor

There's nothing missing. It isn't our code, and the output doesn't differ from the stock factory images. You're also probably using a copy of fastboot from Google, so there's nothing I can do about the output it produces even if I considered it in-scope.

Contributor

thestinger commented Jun 4, 2016

There's nothing missing. It isn't our code, and the output doesn't differ from the stock factory images. You're also probably using a copy of fastboot from Google, so there's nothing I can do about the output it produces even if I considered it in-scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment