video recordings have green bar on left side on Nexus 5 #344

Closed
o1y opened this Issue Jul 17, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@o1y

o1y commented Jul 17, 2016

Recorded video files on the Nexus 5 have a green bar. The root cause is located in Android.mk .

Replace the highlighted code with LOCAL_CFLAGS += -DVENUS_PRESENT, because util is-board-platform-in-list is not available in the code base.

@o1y o1y changed the title from video recording have green bar on left side on Nexus 5 to video recordings have green bar on left side on Nexus 5 Jul 17, 2016

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Jul 18, 2016

Contributor

Has this issue been reported upstream? There are other calls to is-board-platform-in-list. It could be worked around on a case-by-case basis but if so I want to deal with all of them at the same time, and that doesn't seem like a great approach to this. Especially since more of these can creep in down the road for new devices, or simply enhancements to current generation devices (like the 5X and 6P in Android N).

Contributor

thestinger commented Jul 18, 2016

Has this issue been reported upstream? There are other calls to is-board-platform-in-list. It could be worked around on a case-by-case basis but if so I want to deal with all of them at the same time, and that doesn't seem like a great approach to this. Especially since more of these can creep in down the road for new devices, or simply enhancements to current generation devices (like the 5X and 6P in Android N).

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Jul 21, 2016

Contributor

The necessary functions are now included: CopperheadOS/platform_build@600d75d. It will be in the next release.

Contributor

thestinger commented Jul 21, 2016

The necessary functions are now included: CopperheadOS/platform_build@600d75d. It will be in the next release.

@thestinger thestinger closed this Jul 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment