Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
switch to using a monochrome apk instead of separate chrome/webview apks #415
Comments
thestinger
added
Type: enhancement
upstream
labels
Sep 3, 2016
thestinger
referenced this issue
Sep 6, 2016
Closed
WebView for Android Nougat relies on code that is not yet part of upstream Chromium releases #420
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
rsesek
Sep 12, 2016
In order to support users disabling (Mono)Chrome, Android system still ships a SystemWebViewGoogle. That way there's a fallback package to keep WebView working if the Monochrome package is explicitly disabled. If you're not concerned about users disabling Chrome, then you can just use Monochrome.
rsesek
commented
Sep 12, 2016
|
In order to support users disabling (Mono)Chrome, Android system still ships a SystemWebViewGoogle. That way there's a fallback package to keep WebView working if the Monochrome package is explicitly disabled. If you're not concerned about users disabling Chrome, then you can just use Monochrome. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Sep 13, 2016
Contributor
@rsesek The part that I'm unsure about is what the target is to build monochrome. There are chrome_public_apk and system_webview_apk but I don't see one to actually make a Chrome build include the monochrome libraries, or an option to make it do that.
|
@rsesek The part that I'm unsure about is what the target is to build monochrome. There are chrome_public_apk and system_webview_apk but I don't see one to actually make a Chrome build include the monochrome libraries, or an option to make it do that. |
rsesek
commented
Sep 13, 2016
|
The monochrome APK target isn't yet upstreamed. WebView team is working on unforking it, though (should be part of the crbug mentioned in #420). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
rsesek
Sep 28, 2016
There's now a bug dedicated to tracking the public monochrome target: https://bugs.chromium.org/p/chromium/issues/detail?id=650927.
rsesek
commented
Sep 28, 2016
|
There's now a bug dedicated to tracking the public monochrome target: https://bugs.chromium.org/p/chromium/issues/detail?id=650927. |
thestinger
added
the
Component: Chromium
label
Nov 21, 2016
thestinger
added
the
Priority: low
label
Dec 3, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Jun 10, 2017
Contributor
AFAICT, some of the changes required for this landed but now it isn't progressing. It's not super important but it does make our updates significantly bigger which is a bit annoying. Chromium updates aren't frequent enough for it to be a high priority though.
|
AFAICT, some of the changes required for this landed but now it isn't progressing. It's not super important but it does make our updates significantly bigger which is a bit annoying. Chromium updates aren't frequent enough for it to be a high priority though. |
thestinger
added
the
far-future
label
Jun 11, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
rsesek
Jun 16, 2017
I don't know much about the Chromium Android build configuration, but if you can post on the bug what issues are still outstanding, that'd probably be helpful to the people who do know.
rsesek
commented
Jun 16, 2017
|
I don't know much about the Chromium Android build configuration, but if you can post on the bug what issues are still outstanding, that'd probably be helpful to the people who do know. |
thestinger
removed
the
far-future
label
Jul 5, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Jul 5, 2017
Contributor
It turns out that the remaining issues were resolved recently, I just had to deal with porting it to using 64-bit processes:
|
It turns out that the remaining issues were resolved recently, I just had to deal with porting it to using 64-bit processes: |
thestinger commentedSep 3, 2016
It's not clear if the necessary sources are public yet, but this should happen once it becomes possible.