switch to using a monochrome apk instead of separate chrome/webview apks #415

Closed
thestinger opened this Issue Sep 3, 2016 · 7 comments

Comments

Projects
None yet
2 participants
@thestinger
Contributor

thestinger commented Sep 3, 2016

It's not clear if the necessary sources are public yet, but this should happen once it becomes possible.

@rsesek

This comment has been minimized.

Show comment Hide comment
@rsesek

rsesek Sep 12, 2016

In order to support users disabling (Mono)Chrome, Android system still ships a SystemWebViewGoogle. That way there's a fallback package to keep WebView working if the Monochrome package is explicitly disabled. If you're not concerned about users disabling Chrome, then you can just use Monochrome.

rsesek commented Sep 12, 2016

In order to support users disabling (Mono)Chrome, Android system still ships a SystemWebViewGoogle. That way there's a fallback package to keep WebView working if the Monochrome package is explicitly disabled. If you're not concerned about users disabling Chrome, then you can just use Monochrome.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Sep 13, 2016

Contributor

@rsesek The part that I'm unsure about is what the target is to build monochrome. There are chrome_public_apk and system_webview_apk but I don't see one to actually make a Chrome build include the monochrome libraries, or an option to make it do that.

Contributor

thestinger commented Sep 13, 2016

@rsesek The part that I'm unsure about is what the target is to build monochrome. There are chrome_public_apk and system_webview_apk but I don't see one to actually make a Chrome build include the monochrome libraries, or an option to make it do that.

@rsesek

This comment has been minimized.

Show comment Hide comment
@rsesek

rsesek Sep 13, 2016

The monochrome APK target isn't yet upstreamed. WebView team is working on unforking it, though (should be part of the crbug mentioned in #420).

rsesek commented Sep 13, 2016

The monochrome APK target isn't yet upstreamed. WebView team is working on unforking it, though (should be part of the crbug mentioned in #420).

@rsesek

This comment has been minimized.

Show comment Hide comment
@rsesek

rsesek Sep 28, 2016

There's now a bug dedicated to tracking the public monochrome target: https://bugs.chromium.org/p/chromium/issues/detail?id=650927.

rsesek commented Sep 28, 2016

There's now a bug dedicated to tracking the public monochrome target: https://bugs.chromium.org/p/chromium/issues/detail?id=650927.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Jun 10, 2017

Contributor

AFAICT, some of the changes required for this landed but now it isn't progressing. It's not super important but it does make our updates significantly bigger which is a bit annoying. Chromium updates aren't frequent enough for it to be a high priority though.

Contributor

thestinger commented Jun 10, 2017

AFAICT, some of the changes required for this landed but now it isn't progressing. It's not super important but it does make our updates significantly bigger which is a bit annoying. Chromium updates aren't frequent enough for it to be a high priority though.

@rsesek

This comment has been minimized.

Show comment Hide comment
@rsesek

rsesek Jun 16, 2017

I don't know much about the Chromium Android build configuration, but if you can post on the bug what issues are still outstanding, that'd probably be helpful to the people who do know.

rsesek commented Jun 16, 2017

I don't know much about the Chromium Android build configuration, but if you can post on the bug what issues are still outstanding, that'd probably be helpful to the people who do know.

@thestinger thestinger removed the far-future label Jul 5, 2017

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Jul 5, 2017

Contributor

It turns out that the remaining issues were resolved recently, I just had to deal with porting it to using 64-bit processes:

https://github.com/CopperheadOS/chromium_patches/blob/master/0017-use-64-bit-Monochrome-processes.patch

Contributor

thestinger commented Jul 5, 2017

It turns out that the remaining issues were resolved recently, I just had to deal with porting it to using 64-bit processes:

https://github.com/CopperheadOS/chromium_patches/blob/master/0017-use-64-bit-Monochrome-processes.patch

@thestinger thestinger closed this Jul 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment