/bugtracker

Pico TTS unintelligible output #426

Closed
Rudd-O opened this Issue Sep 9, 2016 · 13 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
4 participants
@Rudd-O @thestinger @okblgxag @UnderSampled
@Rudd-O

Rudd-O commented Sep 9, 2016

I'm reporting this issue as it has begun happening with Nougat. One literally cannot understand anything TTS says. Happens at least with Spanish and English TTS voices.
@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Sep 10, 2016

Contributor

Try the latest release (NRD90U.2016.09.09.07.12.48). There were known audio issues in the early releases. They were fixed in NRD90S.2016.09.07.12.31.09.
Contributor

thestinger commented Sep 10, 2016

Try the latest release (NRD90U.2016.09.09.07.12.48). There were known audio issues in the early releases. They were fixed in NRD90S.2016.09.07.12.31.09.

@thestinger thestinger added the Type: bug label Sep 10, 2016

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Sep 10, 2016

Contributor

If this wasn't caused by the known audio issue, then it's possible there's another similar compatibility issue but it's more likely that this is an upstream bug. I don't think stock Android uses Pico so it wouldn't be tested or properly maintained by them, similar to other AOSP-only code.
Contributor

thestinger commented Sep 10, 2016 •
edited
Edited 1 time
  • @thestinger thestinger edited Sep 10, 2016

If this wasn't caused by the known audio issue, then it's possible there's another similar compatibility issue but it's more likely that this is an upstream bug. I don't think stock Android uses Pico so it wouldn't be tested or properly maintained by them, similar to other AOSP-only code.
@Rudd-O

This comment has been minimized.

Show comment Hide comment
@Rudd-O

Rudd-O Sep 12, 2016

This problem remains with the latest release.

Rudd-O commented Sep 12, 2016

This problem remains with the latest release.

@thestinger thestinger added the upstream label Sep 12, 2016

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Sep 12, 2016

Contributor

That implies that this is an upstream issue. I'll keep an eye out for fixes in master, since what tends to happen is that they actually do fix AOSP problems but they never backport those fixes to stables.
Contributor

thestinger commented Sep 12, 2016

That implies that this is an upstream issue. I'll keep an eye out for fixes in master, since what tends to happen is that they actually do fix AOSP problems but they never backport those fixes to stables.
@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Sep 12, 2016

Contributor

Note that there will be some changes to binary blobs soon, which might fix this, but I consider that disaster to be an upstream issue that I need to work around.
Contributor

thestinger commented Sep 12, 2016

Note that there will be some changes to binary blobs soon, which might fix this, but I consider that disaster to be an upstream issue that I need to work around.

@thestinger thestinger referenced this issue Oct 2, 2016

Closed

fix issues caught by -fsanitize=bounds in pico tts #461

@okblgxag

This comment has been minimized.

Show comment Hide comment
@okblgxag

okblgxag Oct 26, 2016

Since it doesn't look like this issue will be fixed, would you consider including an alternative TTS engine such as Flite?

okblgxag commented Oct 26, 2016

Since it doesn't look like this issue will be fixed, would you consider including an alternative TTS engine such as Flite?
@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 26, 2016

Contributor

Only if it's well-maintained and they care about security at least as much as Google does.
Contributor

thestinger commented Oct 26, 2016

Only if it's well-maintained and they care about security at least as much as Google does.
@Rudd-O

This comment has been minimized.

Show comment Hide comment
@Rudd-O

Rudd-O Oct 26, 2016

On 10/26/2016 01:37 AM, okblgxag wrote:

Since it doesn't look like this issue will be fixed, would you
consider including an alternative TTS engine such as Flite
https://github.com/happyalu/Flite-TTS-Engine-for-Android?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#426 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVIwp0dj5rU076QXuCL-7Td3GtM2QDFks5q3q6-gaJpZM4J5G2N.

This TTS engine actually sounds better than Pico TTS. I wish it could
be included, if it wasn't too much work to maintain it.

Rudd-O
http://rudd-o.com/

Rudd-O commented Oct 26, 2016

On 10/26/2016 01:37 AM, okblgxag wrote:

Since it doesn't look like this issue will be fixed, would you
consider including an alternative TTS engine such as Flite
https://github.com/happyalu/Flite-TTS-Engine-for-Android?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#426 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAVIwp0dj5rU076QXuCL-7Td3GtM2QDFks5q3q6-gaJpZM4J5G2N.

This TTS engine actually sounds better than Pico TTS. I wish it could
be included, if it wasn't too much work to maintain it.

Rudd-O
http://rudd-o.com/
@UnderSampled

This comment has been minimized.

Show comment Hide comment
@UnderSampled

UnderSampled Nov 5, 2016

My response to this was to add flite to Fd-Droid. Hopefully it should show up soon. The developer did respond quickly, so I think it's not that bad an idea to include -- but not necessary: I know some ROMs just remove the broken tts. This may actually help get AOSPers to notice the state of TTS.

UnderSampled commented Nov 5, 2016

My response to this was to add flite to Fd-Droid. Hopefully it should show up soon. The developer did respond quickly, so I think it's not that bad an idea to include -- but not necessary: I know some ROMs just remove the broken tts. This may actually help get AOSPers to notice the state of TTS.
@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Nov 6, 2016

Contributor

Maintaining a TTS engine is far out of the scope of CopperheadOS and it doesn't appear that there is any well maintained open source alternative to the included one. Especially not one with attention being given to security issues. Better off using the bitrotted one from Google that will at least get security fixes for issues if they are found. If you want to get it fixed, take it up with Google and do it in AOSP.
Contributor

thestinger commented Nov 6, 2016

Maintaining a TTS engine is far out of the scope of CopperheadOS and it doesn't appear that there is any well maintained open source alternative to the included one. Especially not one with attention being given to security issues. Better off using the bitrotted one from Google that will at least get security fixes for issues if they are found. If you want to get it fixed, take it up with Google and do it in AOSP.

@thestinger thestinger closed this Nov 6, 2016

@Rudd-O

This comment has been minimized.

Show comment Hide comment
@Rudd-O

Rudd-O Nov 7, 2016

On 11/05/2016 11:26 PM, UnderSampled wrote:

My response to this was to add flite to Fd-Droid. Hopefully it should
show up soon. The developer did respond quickly, so I think it's not
that bad an idea to include -- but not necessary: I know some ROMs
just remove the broken tts. This may actually help get AOSPers to
notice the state of TTS.

I can't find flite in F-Droid so far. Hoping it gets added soon.

Thought I'd mention: eSpeak as uploaded in F-Droid is broken too. It
won't load the voices.

Rudd-O
http://rudd-o.com/

Rudd-O commented Nov 7, 2016

On 11/05/2016 11:26 PM, UnderSampled wrote:

My response to this was to add flite to Fd-Droid. Hopefully it should
show up soon. The developer did respond quickly, so I think it's not
that bad an idea to include -- but not necessary: I know some ROMs
just remove the broken tts. This may actually help get AOSPers to
notice the state of TTS.

I can't find flite in F-Droid so far. Hoping it gets added soon.

Thought I'd mention: eSpeak as uploaded in F-Droid is broken too. It
won't load the voices.

Rudd-O
http://rudd-o.com/
@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Nov 13, 2016

Contributor

FWIW, this will be worked around in the next release of CopperheadOS. It turns out that Pico TTS is broken when compiled as 64-bit. They tried to fix it, but they apparently never actually tested it to make sure that it worked.
Contributor

thestinger commented Nov 13, 2016

FWIW, this will be worked around in the next release of CopperheadOS. It turns out that Pico TTS is broken when compiled as 64-bit. They tried to fix it, but they apparently never actually tested it to make sure that it worked.
@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Nov 13, 2016

Contributor

The workaround that I just submitted upstream: https://android-review.googlesource.com/#/c/302872/.
Contributor

thestinger commented Nov 13, 2016

The workaround that I just submitted upstream: https://android-review.googlesource.com/#/c/302872/.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment