Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
conversations app crashing on N build #443
Comments
thestinger
added
Type: bug
upstream-app
labels
Sep 19, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Sep 22, 2016
Contributor
Please try again with the latest Conversations and CopperheadOS.
|
Please try again with the latest Conversations and CopperheadOS. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
canary5
Sep 22, 2016
I have tested both latest versions but still crashing just after boot. But later working good. Crashing first run sometimes two. But noticed some strange thing, if i reboot without internet connection(just wifi off dont have mobile) its not crashing
canary5
commented
Sep 22, 2016
•
|
I have tested both latest versions but still crashing just after boot. But later working good. Crashing first run sometimes two. But noticed some strange thing, if i reboot without internet connection(just wifi off dont have mobile) its not crashing |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
rosswell98
Sep 25, 2016
I have the same problem, but I don't thinks that it's directly related to Conversations.
When peoples talk with me, I can reply without problem in the notifications center, the problem appears when I want to open Conversations.
rosswell98
commented
Sep 25, 2016
|
I have the same problem, but I don't thinks that it's directly related to Conversations. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Sep 27, 2016
Contributor
Check if this is still present with NRD90U.2016.09.27.15.19.19, there are some relevant compatibility fixes.
|
Check if this is still present with NRD90U.2016.09.27.15.19.19, there are some relevant compatibility fixes. |
thestinger
added
the
unconfirmed
label
Sep 28, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
canary5
commented
Sep 28, 2016
•
|
Still same crash |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
rosswell98
commented
Sep 28, 2016
|
For the moment I had no crash with the latest update... |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
canary5
commented
Sep 28, 2016
|
Try reboot your phone. Just after reboot click on conversation icon |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
rosswell98
Sep 28, 2016
I just rebooted now, tried, and I had no problem...
Did you tried to clean the Conversations cache ?
rosswell98
commented
Sep 28, 2016
|
I just rebooted now, tried, and I had no problem... |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
canary5
commented
Sep 28, 2016
|
I will do clean install today |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
rosswell98
Sep 28, 2016
Don't, ignore my last comment, I had the problem like 1 hour after my response...
rosswell98
commented
Sep 28, 2016
|
Don't, ignore my last comment, I had the problem like 1 hour after my response... |
thestinger
removed
the
unconfirmed
label
Sep 28, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
rosswell98
Sep 29, 2016
Conversations 1.14.3 is out on F-Droid did you installed it?
In the changelog:
"Version 1.14.3
fix rare start up crashes"
rosswell98
commented
Sep 29, 2016
|
Conversations 1.14.3 is out on F-Droid did you installed it? fix rare start up crashes" |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
rosswell98
commented
Sep 29, 2016
|
The issue is always here... |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
canary5
Sep 29, 2016
I have tested on another N system. No crash, so its copperhead issue it think. I opened ticked on conversations. But they doubt its conversations issue as well
canary5
commented
Sep 29, 2016
|
I have tested on another N system. No crash, so its copperhead issue it think. I opened ticked on conversations. But they doubt its conversations issue as well |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
rosswell98
Sep 29, 2016
I see. The issue is confirmed... Conversation can be openned after 2-3 tries, just wait for the fix...
rosswell98
commented
Sep 29, 2016
|
I see. The issue is confirmed... Conversation can be openned after 2-3 tries, just wait for the fix... |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
lagosazules
Oct 21, 2016
Still no ETA for this fix? It is very annoying this CopperheadOS bug, Conversations is in my opinion one of the most important application, hope for a quick solucion.
lagosazules
commented
Oct 21, 2016
|
Still no ETA for this fix? It is very annoying this CopperheadOS bug, Conversations is in my opinion one of the most important application, hope for a quick solucion. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
ETA == when one of you feels like contributing a fix for it. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Oct 21, 2016
Contributor
It's probably caused by exec spawning. Step one: make a build without exec spawning. Revert 514fe7f117db62704d8759d83c27ad8fc3ccbf8b and eb00f8dff5dfb4ac080540a9179dca30b48cca28 (in that order).
If that doesn't work, revert b8d123b8554f34cfea46148b248c84e9ecd190e5 and then fa54c344d37380414e1cab5d037fe10301e6d38b in that order too. If that works, revert the eb00f8dff5dfb4ac080540a9179dca30b48cca28 revert then the 514fe7f117db62704d8759d83c27ad8fc3ccbf8b revert to determine if enabling preloading while still using exec spawning fixes it.
That's the easy part. Assuming one of those things is the cause, figure out why it happens. Doing that kind of thing will often take days of work or more. Can use a debugger, strace, perf trace, etc. It seems to be a race, so setting affinity to pin to a single core might help with debugging. Maybe it's something that TSan could figure out but I doubt it.
|
It's probably caused by exec spawning. Step one: make a build without exec spawning. Revert 514fe7f117db62704d8759d83c27ad8fc3ccbf8b and eb00f8dff5dfb4ac080540a9179dca30b48cca28 (in that order). If that doesn't work, revert b8d123b8554f34cfea46148b248c84e9ecd190e5 and then fa54c344d37380414e1cab5d037fe10301e6d38b in that order too. If that works, revert the eb00f8dff5dfb4ac080540a9179dca30b48cca28 revert then the 514fe7f117db62704d8759d83c27ad8fc3ccbf8b revert to determine if enabling preloading while still using exec spawning fixes it. That's the easy part. Assuming one of those things is the cause, figure out why it happens. Doing that kind of thing will often take days of work or more. Can use a debugger, strace, perf trace, etc. It seems to be a race, so setting affinity to pin to a single core might help with debugging. Maybe it's something that TSan could figure out but I doubt it. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Oct 21, 2016
Contributor
Not planning on working on it though. It seems like an AOSP or app bug uncovered by exec spawning. So I need evidence it's a CopperheadOS bug to devote my limited time to working on it. That's how this works.
|
Not planning on working on it though. It seems like an AOSP or app bug uncovered by exec spawning. So I need evidence it's a CopperheadOS bug to devote my limited time to working on it. That's how this works. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Oct 21, 2016
Contributor
In my experience, people start contributing to projects by fixing issues that annoy them. So I plan on working on under the hood stuff that's not incredibly annoying to leave the door wide open to contributors. If people finally start contributing, it's going to be because there's stuff like this to figure out. On the other hand, no one is going to step up to fix one of the memory corruption bugs caught by our mitigations while running the Compatibility Test Suite. Someone might complain about a "random" reboot now and then, but that won't go anywhere. There's a huge amount of work to do, so there's a lot of choice in terms of important issues to work on. Issues like this also aren't particularly important if they are really an AOSP bug that Google might get around to fixing for it. That happens quite often.
|
In my experience, people start contributing to projects by fixing issues that annoy them. So I plan on working on under the hood stuff that's not incredibly annoying to leave the door wide open to contributors. If people finally start contributing, it's going to be because there's stuff like this to figure out. On the other hand, no one is going to step up to fix one of the memory corruption bugs caught by our mitigations while running the Compatibility Test Suite. Someone might complain about a "random" reboot now and then, but that won't go anywhere. There's a huge amount of work to do, so there's a lot of choice in terms of important issues to work on. Issues like this also aren't particularly important if they are really an AOSP bug that Google might get around to fixing for it. That happens quite often. |
lagosazules
referenced this issue
in siacs/Conversations
Oct 21, 2016
Closed
crashing after upgrading to android N #2029
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
lagosazules
Oct 21, 2016
I do understand and respect your choice, sorry I can't help to find this bug, you are realy doing a great job but I think what to do with this N version and have to use one of the best and only xmpp onemo interfaces with this bug? Copperhead needs the use of the most secure apps and Conversations is one of them.
lagosazules
commented
Oct 21, 2016
|
I do understand and respect your choice, sorry I can't help to find this bug, you are realy doing a great job but I think what to do with this N version and have to use one of the best and only xmpp onemo interfaces with this bug? Copperhead needs the use of the most secure apps and Conversations is one of them. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Oct 21, 2016
Contributor
So submit a patch for it if you want it to work properly. It does work if you open it enough times. It's probably a race condition.
|
So submit a patch for it if you want it to work properly. It does work if you open it enough times. It's probably a race condition. |
thestinger
added
the
Priority: low
label
Oct 21, 2016
thestinger
added this to the Release milestone
Oct 22, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
iNPUTmice
Oct 28, 2016
I created a Conversations branch that might have a work around (not a fix) for this.
I'd be interested to know if this works https://github.com/siacs/Conversations/tree/possible_copperhead_fixes
iNPUTmice
commented
Oct 28, 2016
|
I created a Conversations branch that might have a work around (not a fix) for this. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
lagosazules
Oct 29, 2016
I do not have a 5x at this moment to check it out, thanks for your work on this, it looks like no one is using a CopperheadOS Conversations combination.
lagosazules
commented
Oct 29, 2016
|
I do not have a 5x at this moment to check it out, thanks for your work on this, it looks like no one is using a CopperheadOS Conversations combination. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
canary5
Oct 29, 2016
Hi. Its still crashing for me. I just tested this build. Thanks a lot for your efforts
canary5
commented
Oct 29, 2016
|
Hi. Its still crashing for me. I just tested this build. Thanks a lot for your efforts |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
rosswell98
Oct 29, 2016
I have a N5X, with CopperheadOS and Conversations.
Since last update (of CopperheadOS) I had no crashes for now...
rosswell98
commented
Oct 29, 2016
|
I have a N5X, with CopperheadOS and Conversations. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Oct 29, 2016
Contributor
The issue is still present. It's a race condition. I need someone to spend time working on it, not testing to see if it's present (it is).
|
The issue is still present. It's a race condition. I need someone to spend time working on it, not testing to see if it's present (it is). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
A workaround for this AOSP bug is in today's release. |
thestinger
added
the
Status: workaround in place
label
Nov 10, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Nov 10, 2016
Contributor
The AOSP bug is not fixed so this will remain open to track that, along with the removal of the workaround.
|
The AOSP bug is not fixed so this will remain open to track that, along with the removal of the workaround. |
thestinger
added
upstream
and removed
upstream-app
labels
Nov 10, 2016
thestinger
removed this from the Release milestone
Nov 10, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
lagosazules
commented
Nov 10, 2016
|
Working fine, Thanks Copperhead team ! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
canary5
commented
Nov 10, 2016
|
Thanks a lot, great work! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
Replacing this issue with #491. |
thestinger
closed this
Nov 17, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Sep 9, 2017
Contributor
@iNPUTmice Google finally fixed this in https://android.googlesource.com/platform/frameworks/base/+/e2179925df2ce174d81dd6f7abae626cc859ce00.
|
@iNPUTmice Google finally fixed this in https://android.googlesource.com/platform/frameworks/base/+/e2179925df2ce174d81dd6f7abae626cc859ce00. |
canary5 commentedSep 19, 2016
Not sure if its app or N problem, just added you a log to take a look.
http://pastebin.com/8BFsQAcP