conversations app crashing on N build #443

Closed
canary5 opened this Issue Sep 19, 2016 · 32 comments

Comments

Projects
None yet
5 participants
@canary5

canary5 commented Sep 19, 2016

Not sure if its app or N problem, just added you a log to take a look.
http://pastebin.com/8BFsQAcP

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Sep 22, 2016

Contributor

Please try again with the latest Conversations and CopperheadOS.

Contributor

thestinger commented Sep 22, 2016

Please try again with the latest Conversations and CopperheadOS.

@canary5

This comment has been minimized.

Show comment Hide comment
@canary5

canary5 Sep 22, 2016

I have tested both latest versions but still crashing just after boot. But later working good. Crashing first run sometimes two. But noticed some strange thing, if i reboot without internet connection(just wifi off dont have mobile) its not crashing

canary5 commented Sep 22, 2016

I have tested both latest versions but still crashing just after boot. But later working good. Crashing first run sometimes two. But noticed some strange thing, if i reboot without internet connection(just wifi off dont have mobile) its not crashing

@rosswell98

This comment has been minimized.

Show comment Hide comment
@rosswell98

rosswell98 Sep 25, 2016

I have the same problem, but I don't thinks that it's directly related to Conversations.
When peoples talk with me, I can reply without problem in the notifications center, the problem appears when I want to open Conversations.

I have the same problem, but I don't thinks that it's directly related to Conversations.
When peoples talk with me, I can reply without problem in the notifications center, the problem appears when I want to open Conversations.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Sep 27, 2016

Contributor

Check if this is still present with NRD90U.2016.09.27.15.19.19, there are some relevant compatibility fixes.

Contributor

thestinger commented Sep 27, 2016

Check if this is still present with NRD90U.2016.09.27.15.19.19, there are some relevant compatibility fixes.

@canary5

This comment has been minimized.

Show comment Hide comment
@canary5

canary5 Sep 28, 2016

Still same crash

canary5 commented Sep 28, 2016

Still same crash

@rosswell98

This comment has been minimized.

Show comment Hide comment
@rosswell98

rosswell98 Sep 28, 2016

For the moment I had no crash with the latest update...

For the moment I had no crash with the latest update...

@canary5

This comment has been minimized.

Show comment Hide comment
@canary5

canary5 Sep 28, 2016

Try reboot your phone. Just after reboot click on conversation icon

canary5 commented Sep 28, 2016

Try reboot your phone. Just after reboot click on conversation icon

@rosswell98

This comment has been minimized.

Show comment Hide comment
@rosswell98

rosswell98 Sep 28, 2016

I just rebooted now, tried, and I had no problem...
Did you tried to clean the Conversations cache ?

I just rebooted now, tried, and I had no problem...
Did you tried to clean the Conversations cache ?

@canary5

This comment has been minimized.

Show comment Hide comment
@canary5

canary5 Sep 28, 2016

I will do clean install today

canary5 commented Sep 28, 2016

I will do clean install today

@rosswell98

This comment has been minimized.

Show comment Hide comment
@rosswell98

rosswell98 Sep 28, 2016

Don't, ignore my last comment, I had the problem like 1 hour after my response...

Don't, ignore my last comment, I had the problem like 1 hour after my response...

@thestinger thestinger removed the unconfirmed label Sep 28, 2016

@rosswell98

This comment has been minimized.

Show comment Hide comment
@rosswell98

rosswell98 Sep 29, 2016

Conversations 1.14.3 is out on F-Droid did you installed it?
In the changelog:
"Version 1.14.3


fix rare start up crashes"

Conversations 1.14.3 is out on F-Droid did you installed it?
In the changelog:
"Version 1.14.3


fix rare start up crashes"

@rosswell98

This comment has been minimized.

Show comment Hide comment
@rosswell98

rosswell98 Sep 29, 2016

The issue is always here...
I don't think thats a CopperheadOS issue...

The issue is always here...
I don't think thats a CopperheadOS issue...

@canary5

This comment has been minimized.

Show comment Hide comment
@canary5

canary5 Sep 29, 2016

I have tested on another N system. No crash, so its copperhead issue it think. I opened ticked on conversations. But they doubt its conversations issue as well

canary5 commented Sep 29, 2016

I have tested on another N system. No crash, so its copperhead issue it think. I opened ticked on conversations. But they doubt its conversations issue as well

@rosswell98

This comment has been minimized.

Show comment Hide comment
@rosswell98

rosswell98 Sep 29, 2016

I see. The issue is confirmed... Conversation can be openned after 2-3 tries, just wait for the fix...

I see. The issue is confirmed... Conversation can be openned after 2-3 tries, just wait for the fix...

@lagosazules

This comment has been minimized.

Show comment Hide comment
@lagosazules

lagosazules Oct 21, 2016

Still no ETA for this fix? It is very annoying this CopperheadOS bug, Conversations is in my opinion one of the most important application, hope for a quick solucion.

Still no ETA for this fix? It is very annoying this CopperheadOS bug, Conversations is in my opinion one of the most important application, hope for a quick solucion.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 21, 2016

Contributor

ETA == when one of you feels like contributing a fix for it.

Contributor

thestinger commented Oct 21, 2016

ETA == when one of you feels like contributing a fix for it.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 21, 2016

Contributor

It's probably caused by exec spawning. Step one: make a build without exec spawning. Revert 514fe7f117db62704d8759d83c27ad8fc3ccbf8b and eb00f8dff5dfb4ac080540a9179dca30b48cca28 (in that order).

If that doesn't work, revert b8d123b8554f34cfea46148b248c84e9ecd190e5 and then fa54c344d37380414e1cab5d037fe10301e6d38b in that order too. If that works, revert the eb00f8dff5dfb4ac080540a9179dca30b48cca28 revert then the 514fe7f117db62704d8759d83c27ad8fc3ccbf8b revert to determine if enabling preloading while still using exec spawning fixes it.

That's the easy part. Assuming one of those things is the cause, figure out why it happens. Doing that kind of thing will often take days of work or more. Can use a debugger, strace, perf trace, etc. It seems to be a race, so setting affinity to pin to a single core might help with debugging. Maybe it's something that TSan could figure out but I doubt it.

Contributor

thestinger commented Oct 21, 2016

It's probably caused by exec spawning. Step one: make a build without exec spawning. Revert 514fe7f117db62704d8759d83c27ad8fc3ccbf8b and eb00f8dff5dfb4ac080540a9179dca30b48cca28 (in that order).

If that doesn't work, revert b8d123b8554f34cfea46148b248c84e9ecd190e5 and then fa54c344d37380414e1cab5d037fe10301e6d38b in that order too. If that works, revert the eb00f8dff5dfb4ac080540a9179dca30b48cca28 revert then the 514fe7f117db62704d8759d83c27ad8fc3ccbf8b revert to determine if enabling preloading while still using exec spawning fixes it.

That's the easy part. Assuming one of those things is the cause, figure out why it happens. Doing that kind of thing will often take days of work or more. Can use a debugger, strace, perf trace, etc. It seems to be a race, so setting affinity to pin to a single core might help with debugging. Maybe it's something that TSan could figure out but I doubt it.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 21, 2016

Contributor

Not planning on working on it though. It seems like an AOSP or app bug uncovered by exec spawning. So I need evidence it's a CopperheadOS bug to devote my limited time to working on it. That's how this works.

Contributor

thestinger commented Oct 21, 2016

Not planning on working on it though. It seems like an AOSP or app bug uncovered by exec spawning. So I need evidence it's a CopperheadOS bug to devote my limited time to working on it. That's how this works.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 21, 2016

Contributor

In my experience, people start contributing to projects by fixing issues that annoy them. So I plan on working on under the hood stuff that's not incredibly annoying to leave the door wide open to contributors. If people finally start contributing, it's going to be because there's stuff like this to figure out. On the other hand, no one is going to step up to fix one of the memory corruption bugs caught by our mitigations while running the Compatibility Test Suite. Someone might complain about a "random" reboot now and then, but that won't go anywhere. There's a huge amount of work to do, so there's a lot of choice in terms of important issues to work on. Issues like this also aren't particularly important if they are really an AOSP bug that Google might get around to fixing for it. That happens quite often.

Contributor

thestinger commented Oct 21, 2016

In my experience, people start contributing to projects by fixing issues that annoy them. So I plan on working on under the hood stuff that's not incredibly annoying to leave the door wide open to contributors. If people finally start contributing, it's going to be because there's stuff like this to figure out. On the other hand, no one is going to step up to fix one of the memory corruption bugs caught by our mitigations while running the Compatibility Test Suite. Someone might complain about a "random" reboot now and then, but that won't go anywhere. There's a huge amount of work to do, so there's a lot of choice in terms of important issues to work on. Issues like this also aren't particularly important if they are really an AOSP bug that Google might get around to fixing for it. That happens quite often.

@lagosazules lagosazules referenced this issue in siacs/Conversations Oct 21, 2016

Closed

crashing after upgrading to android N #2029

@lagosazules

This comment has been minimized.

Show comment Hide comment
@lagosazules

lagosazules Oct 21, 2016

I do understand and respect your choice, sorry I can't help to find this bug, you are realy doing a great job but I think what to do with this N version and have to use one of the best and only xmpp onemo interfaces with this bug? Copperhead needs the use of the most secure apps and Conversations is one of them.

I do understand and respect your choice, sorry I can't help to find this bug, you are realy doing a great job but I think what to do with this N version and have to use one of the best and only xmpp onemo interfaces with this bug? Copperhead needs the use of the most secure apps and Conversations is one of them.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 21, 2016

Contributor

So submit a patch for it if you want it to work properly. It does work if you open it enough times. It's probably a race condition.

Contributor

thestinger commented Oct 21, 2016

So submit a patch for it if you want it to work properly. It does work if you open it enough times. It's probably a race condition.

@thestinger thestinger added this to the Release milestone Oct 22, 2016

@iNPUTmice

This comment has been minimized.

Show comment Hide comment
@iNPUTmice

iNPUTmice Oct 28, 2016

I created a Conversations branch that might have a work around (not a fix) for this.
I'd be interested to know if this works https://github.com/siacs/Conversations/tree/possible_copperhead_fixes

I created a Conversations branch that might have a work around (not a fix) for this.
I'd be interested to know if this works https://github.com/siacs/Conversations/tree/possible_copperhead_fixes

@lagosazules

This comment has been minimized.

Show comment Hide comment
@lagosazules

lagosazules Oct 29, 2016

I do not have a 5x at this moment to check it out, thanks for your work on this, it looks like no one is using a CopperheadOS Conversations combination.

I do not have a 5x at this moment to check it out, thanks for your work on this, it looks like no one is using a CopperheadOS Conversations combination.

@canary5

This comment has been minimized.

Show comment Hide comment
@canary5

canary5 Oct 29, 2016

Hi. Its still crashing for me. I just tested this build. Thanks a lot for your efforts

canary5 commented Oct 29, 2016

Hi. Its still crashing for me. I just tested this build. Thanks a lot for your efforts

@rosswell98

This comment has been minimized.

Show comment Hide comment
@rosswell98

rosswell98 Oct 29, 2016

I have a N5X, with CopperheadOS and Conversations.
Since last update (of CopperheadOS) I had no crashes for now...

I have a N5X, with CopperheadOS and Conversations.
Since last update (of CopperheadOS) I had no crashes for now...

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 29, 2016

Contributor

The issue is still present. It's a race condition. I need someone to spend time working on it, not testing to see if it's present (it is).

Contributor

thestinger commented Oct 29, 2016

The issue is still present. It's a race condition. I need someone to spend time working on it, not testing to see if it's present (it is).

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Nov 10, 2016

Contributor

A workaround for this AOSP bug is in today's release.

Contributor

thestinger commented Nov 10, 2016

A workaround for this AOSP bug is in today's release.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Nov 10, 2016

Contributor

The AOSP bug is not fixed so this will remain open to track that, along with the removal of the workaround.

Contributor

thestinger commented Nov 10, 2016

The AOSP bug is not fixed so this will remain open to track that, along with the removal of the workaround.

@thestinger thestinger added upstream and removed upstream-app labels Nov 10, 2016

@thestinger thestinger removed this from the Release milestone Nov 10, 2016

@lagosazules

This comment has been minimized.

Show comment Hide comment
@lagosazules

lagosazules Nov 10, 2016

Working fine, Thanks Copperhead team !

Working fine, Thanks Copperhead team !

@canary5

This comment has been minimized.

Show comment Hide comment
@canary5

canary5 Nov 10, 2016

Thanks a lot, great work!

canary5 commented Nov 10, 2016

Thanks a lot, great work!

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Nov 17, 2016

Contributor

Replacing this issue with #491.

Contributor

thestinger commented Nov 17, 2016

Replacing this issue with #491.

@thestinger thestinger closed this Nov 17, 2016

@thestinger

This comment has been minimized.

Show comment Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment