Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
fix issues caught by -fsanitize=bounds in pico tts #461
Comments
thestinger
added
Type: bug
upstream
Status: workaround in place
Component: ubsan
labels
Sep 27, 2016
thestinger
changed the title from
bounds sanitizer violation in pico tts
to
fix issues caught by -fsanitize=bounds in pico tts
Sep 28, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
jgeerds
Oct 2, 2016
What is the exact issue?
On a ~ 10 days old build of CopperheadOS Pico TTS were broken on my Nexus 5X. Today I updated to the latest version and now it works (i.e. it doesn't crash anymore) but the sound is pretty bad. To be honest, it's so bad that it is unusable. Pico TTS worked pretty well for me on the previous Android (Lollipop?) version. Are these the issues you mean?
jgeerds
commented
Oct 2, 2016
|
What is the exact issue? On a ~ 10 days old build of CopperheadOS Pico TTS were broken on my Nexus 5X. Today I updated to the latest version and now it works (i.e. it doesn't crash anymore) but the sound is pretty bad. To be honest, it's so bad that it is unusable. Pico TTS worked pretty well for me on the previous Android (Lollipop?) version. Are these the issues you mean? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Oct 2, 2016
Contributor
It's unlikely that these upstream out-of-bounds access bugs are the cause of the poor sound quality. The bounds sanitizer is disabled for this library and other code where it catches issues during regular use. It's not within the scope of CopperheadOS to fix every upstream bug.
|
It's unlikely that these upstream out-of-bounds access bugs are the cause of the poor sound quality. The bounds sanitizer is disabled for this library and other code where it catches issues during regular use. It's not within the scope of CopperheadOS to fix every upstream bug. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Oct 2, 2016
Contributor
For the sound quality issue, see #426. It's probably an AOSP issue so it's not something that we are going to act on. If a set of clean fixes are put together for the pico tts issues, we'll apply them. Ideally, they should be submitted upstream too.
|
For the sound quality issue, see #426. It's probably an AOSP issue so it's not something that we are going to act on. If a set of clean fixes are put together for the pico tts issues, we'll apply them. Ideally, they should be submitted upstream too. |
thestinger
added
the
Priority: low
label
Apr 8, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Aug 6, 2017
Contributor
Not going to track these upstream bugs here anymore. The canonical list of exceptions is in our sources.
|
Not going to track these upstream bugs here anymore. The canonical list of exceptions is in our sources. |
thestinger commentedSep 27, 2016
No description provided.