Missed call notification LED #663

Closed
mke208 opened this Issue Jul 7, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@mke208

mke208 commented Jul 7, 2017

Speaking of the previous SIP issue, can someone else check if the notification LED blinks on missed call ?
Mine does not seem to ...
Device Pixel XL copperheados-nougat-mr2-release
Blink Notification Light is enabled, Linphone and other apps do make the LED blink

Edited for more clarification and details:
Android native sip client, phone in plane mode and over WiFi. When you have a missed call, the "Missed Call" notification is shown, but the LED is not blinking even if "blink notification light" active in settings.
I cannot confirm this behavior with "regular" calls as i only use the phone with data and SIP calling, and i normally use Linphone. On Linphone the missed call notification makes the LED blink btw.
Identical behavior on another device running LineageOS 7.0.2, so i guess this is an upstream issue, and obviously of very low importance, as the native android SIP calling is quite primitive anyway, with lots of missing features for a modern SIP client, but maybe someone cares.

Off topic: you can make a change to device///liblight/lights.c and set
#define LIGHTS_SUPPORT_BATTERY 1
you get a nice red blinking light when battery is low and different colors when charging, it works on Pixel XL and i am pretty sure it will work on all devices.

@greatuser2

This comment has been minimized.

Show comment Hide comment
@greatuser2

greatuser2 Jul 8, 2017

Checked on Nexus 5x with "regular" calls. The LED doesn't blink.

Checked on Nexus 5x with "regular" calls. The LED doesn't blink.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Jul 8, 2017

Contributor

The notification LED only blinks if an app requests it for a notification. This is working as they intended, the same way as stock Android. It's not within the scope of this issue tracker.

Contributor

thestinger commented Jul 8, 2017

The notification LED only blinks if an app requests it for a notification. This is working as they intended, the same way as stock Android. It's not within the scope of this issue tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment