Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Build failures with latest marlin tag #759
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Oct 3, 2017
Contributor
You need to do this step now because we stopped publishing vendor repositories ourselves:
https://copperhead.co/android/docs/building#extracting-vendor-files-for-nexus-and-pixel-devices
This is a case where an incremental build will probably be fine.
You might also need to run git clean -fdx in the android-prepare-vendor repository before building. There are some reports of issues when not doing that which I wasn't able to reproduce.
|
You need to do this step now because we stopped publishing vendor repositories ourselves: https://copperhead.co/android/docs/building#extracting-vendor-files-for-nexus-and-pixel-devices This is a case where an incremental build will probably be fine. You might also need to run |
thestinger
closed this
Oct 3, 2017
thestinger
added
the
Type: question
label
Oct 3, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Oct 3, 2017
Contributor
We have some permissions to redistribute code but putting it on GitHub is going to lead to problems.
|
We have some permissions to redistribute code but putting it on GitHub is going to lead to problems. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
Rudd-O
Oct 3, 2017
That piece of junk developers.google.com page mentioned in the docs simply does nothing when I hit ACKNOWLEDGE. What do I do?
Rudd-O
commented
Oct 3, 2017
|
That piece of junk developers.google.com page mentioned in the docs simply does nothing when I hit ACKNOWLEDGE. What do I do? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Oct 3, 2017
Contributor
The BUILD_ID value is currently just the first part of the CopperheadOS version for all devices (OPR3.170623.008 for Pixels) but that isn't always the case.
|
The BUILD_ID value is currently just the first part of the CopperheadOS version for all devices (OPR3.170623.008 for Pixels) but that isn't always the case. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
Rudd-O
Oct 3, 2017
Actually, without an automated way of retrieving the images from Google — and the factory images download page is absolutely bulletproof against that — there is no way I can do my builds, because I can't be expected to download the image by hand every time and put it in my build server. I can't even list the available builds in the page!
How do your automated build scripts obtain the factory images from Google?
Rudd-O
commented
Oct 3, 2017
•
edited
Edited 1 time
-
Rudd-O
edited Oct 3, 2017
edited
-
Oct 3, 2017
|
Actually, without an automated way of retrieving the images from Google — and the factory images download page is absolutely bulletproof against that — there is no way I can do my builds, because I can't be expected to download the image by hand every time and put it in my build server. I can't even list the available builds in the page! How do your automated build scripts obtain the factory images from Google? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
Rudd-O
Oct 3, 2017
Aha. The commands do it. It's not clear from the docs. Instructions just say "Extract...".
Rudd-O
commented
Oct 3, 2017
•
edited
Edited 1 time
-
Rudd-O
edited
Oct 3, 2017
edited
-
Oct 3, 2017
|
Aha. The commands do it. It's not clear from the docs. Instructions just say "Extract...". |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Oct 3, 2017
Contributor
Looking at the page is only needed to find the right build id. That's how I figure out which build id to use for the month and then I find the corresponding tag by looking at the tags in platform/build (aka build/make) to figure out which tag has that build id. The code is rebased onto the new tag and I generate new vendor files from the factory images for that tag / build id.
I still keep the vendor files in Git repositories, but other people are expected to fetch them via the same scripts on their own now.
|
Looking at the page is only needed to find the right build id. That's how I figure out which build id to use for the month and then I find the corresponding tag by looking at the tags in platform/build (aka build/make) to figure out which tag has that build id. The code is rebased onto the new tag and I generate new vendor files from the factory images for that tag / build id. I still keep the vendor files in Git repositories, but other people are expected to fetch them via the same scripts on their own now. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
Rudd-O
Oct 4, 2017
It doesn't work anyway. After running this in the src/ directory:
# Obtain Google official images
if [[ $PRODUCT_NAME == hikey* ]]; then
true
else
cd "$BUILD_DIR"/src
vendor/android-prepare-vendor/execute-all.sh -d "$PRODUCT_NAME" -b "$BUILD_ID" -o vendor/android-prepare-vendor
lowerbuildid=$(echo "$BUILD_ID" | tr '[:upper:]' '[:lower:]')
mkdir -p vendor/google_devices
rsync -av --delete \
vendor/android-prepare-vendor/"$PRODUCT_NAME"/"$lowerbuildid"/vendor/google_devices/"$PRODUCT_NAME"/ \
vendor/google_devices/"$PRODUCT_NAME"
fi
The thing says this:
============================================
ninja: no work to do.
[1/3] glob vendor/*/*/Android.bp
[2/3] glob build/tools/*/Android.bp
[1/3] glob vendor/*/*/Android.bp
$(shell build/core/find-jdk-tools-jar.sh) was changed, regenerating...
[1/981] including out/soong/Android-aosp_marlin.mk ...
[2/981] including ./art/Android.mk ...
[3/981] including ./bionic/Android.mk ...
[4/981] including ./bootable/recovery/Android.mk ...
[5/981] including ./build/make/Android.mk ...
[6/981] including ./build/target/board/Android.mk ...
./kernel/google/marlin/AndroidKernel.mk:24: warning: Forcing kernel header generation only for 'arm64'
Using appended DTB
[7/981] including ./build/target/product/security/Android.mk ...
[8/981] including ./build/tools/Android.mk ...
[9/981] including ./cts/Android.mk ...
cts/apps/CtsVerifier/Android.mk:72: warning: FindEmulator: find: `cts/apps/CtsVerifier/src/com/android/cts/verifier/backup': No such file or directory
build/core/java_common.mk:88: warning: FindEmulator: cd: cts/hostsidetests/appsecurity/test-apps/WriteExternalStorageApp/cts/hostsidetests/appsecurity/test-apps/WriteExternalStorageApp/res: No such file or directory
build/core/java_common.mk:88: warning: FindEmulator: cd: cts/hostsidetests/backup/assets: No such file or directory
cts/hostsidetests/os/test-apps/StaticSharedNativeLibProvider/Android.mk:23: warning: FindEmulator: find: `cts/hostsidetests/os/test-apps/StaticSharedNativeLibProvider/src': No such file or directory
cts/hostsidetests/os/test-apps/StaticSharedNativeLibProvider1/Android.mk:23: warning: FindEmulator: find: `cts/hostsidetests/os/test-apps/StaticSharedNativeLibProvider1/src': No such file or directory
cts/tests/tests/contactsproviderwipe/Android.mk:33: warning: FindEmulator: find: `cts/tests/tests/contactsproviderwipe/common/src': No such file or directory
cts/tests/tests/telecom3/Android.mk:37: warning: FindEmulator: find: `cts/tests/tests/telecom/src/android/telecom/cts/MockDialerActivity.java': No such file or directory
[10/981] including ./dalvik/Android.mk ...
[11/981] including ./developers/samples/android/security/FingerprintDialog/Application/src/main/Android.mk ...
[12/981] including ./development/apps/BluetoothDebug/Android.mk ...
[13/981] including ./development/apps/BuildWidget/Android.mk ...
[14/981] including ./development/apps/CustomLocale/Android.mk ...
[15/981] including ./development/apps/Development/Android.mk ...
[16/981] including ./development/apps/DevelopmentSettings/Android.mk ...
[17/981] including ./development/apps/Fallback/Android.mk ...
[18/981] including ./development/apps/GestureBuilder/Android.mk ...
[19/981] including ./development/apps/NinePatchLab/Android.mk ...
[20/981] including ./development/apps/OBJViewer/Android.mk ...
[21/981] including ./development/apps/PushApiAuthenticator/Android.mk ...
[22/981] including ./development/apps/PushApiTestAppOne/Android.mk ...
[23/981] including ./development/apps/PushApiTestAppTwo/Android.mk ...
...
[980/981] including ./vendor/android-prepare-vendor/marlin/opr3.170623.008/vendor/google_devices/marlin/Android.mk ...
[981/981] including ./vendor/google_devices/marlin/Android.mk ...
build/core/base_rules.mk:238: error: vendor/google_devices/marlin: MODULE.TARGET.APPS.atfwd already defined by vendor/google_devices/marlin.
23:59:07 ckati failed with: exit status 1
build/core/main.mk:21: recipe for target 'run_soong_ui' failed
make: *** [run_soong_ui] Error 1
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
ERROR: script returned exit code 2
Finished: FAILURE
Rudd-O
commented
Oct 4, 2017
|
It doesn't work anyway. After running this in the src/ directory: The thing says this: |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Oct 4, 2017
Contributor
Run git clean -fdx in vendor/android-prepare-vendor. I need some way of preventing the build system from looking in there.
|
Run |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
Rudd-O
Oct 4, 2017
I nuked the entire src/ directory before the build. No difference. Do you mean I must run this at some specific point during the build?
Rudd-O
commented
Oct 4, 2017
|
I nuked the entire src/ directory before the build. No difference. Do you mean I must run this at some specific point during the build? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
Rudd-O
Oct 4, 2017
OK. I got it to work with gitcleanfxd right after the factory unzip.
My copperheados-build repo has been updated. Would you like to collaborate on an ongoing basis with it? Other people have begun using it too.
Rudd-O
commented
Oct 4, 2017
|
OK. I got it to work with gitcleanfxd right after the factory unzip. My copperheados-build repo has been updated. Would you like to collaborate on an ongoing basis with it? Other people have begun using it too. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Oct 4, 2017
Contributor
It would be nice if people helped improve things like preventing this issue from happening with android-prepare-vendor without manual intervention, etc. but it seems that isn't going to happen and I've given up on it due to lack of time.
|
It would be nice if people helped improve things like preventing this issue from happening with android-prepare-vendor without manual intervention, etc. but it seems that isn't going to happen and I've given up on it due to lack of time. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Oct 4, 2017
Contributor
I need to focus on maintenance, porting features to Oreo from Nougat and implementing some high priority essential privacy / security features that are missing. There's no time to work on any frills or improving the build experience without help and that's still the case if we hire full-time developers.
|
I need to focus on maintenance, porting features to Oreo from Nougat and implementing some high priority essential privacy / security features that are missing. There's no time to work on any frills or improving the build experience without help and that's still the case if we hire full-time developers. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
Rudd-O
Oct 4, 2017
Rudd-O
commented
Oct 4, 2017
|
What I mean to say is that I could help you maintain these things, and I would let you contribute to my repo, so that we have one single maintenance burden divided by two. I plan to maintain this for a long time, simply cos I need it.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Oct 5, 2017
Contributor
It would be welcome for people to help with things like making F-Droid automatically use the right keys, dealing with this android-prepare-vendor issue, etc. I'm overloaded with work. I can't work on something else too.
|
It would be welcome for people to help with things like making F-Droid automatically use the right keys, dealing with this android-prepare-vendor issue, etc. I'm overloaded with work. I can't work on something else too. |
Rudd-O commentedOct 3, 2017
The finished target_files fails to contain a bootloader.img, in fact the whole RADIO/ folder is missing. What gives? What can I give you to help you debug the problem?