Copying text from K9 seems to be broken #766

Closed
vanitasvitae opened this Issue Oct 12, 2017 · 30 comments

Comments

Projects
None yet
3 participants
@vanitasvitae

Hi!
When I open a mail in k9, long click the content to select some text and then copy it to the clipboard, the text doesn't actually get copied. The clipboard remains unchanged.

I reported this behavior in the k9 bugtracker, but they told me its an issue with coppherheadOS. Copying text in other parts of the OS seems fine though.

k9mail/k-9#2826

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 12, 2017

Contributor

You can turn on background clipboard access in Settings -> Security but note that it's code from Google that we're just actively for other types of apps:

CopperheadOS/platform_frameworks_base@fb71057

Eventually, Google will ship this for normal apps too. They're doing it for instant apps already.

Contributor

thestinger commented Oct 12, 2017

You can turn on background clipboard access in Settings -> Security but note that it's code from Google that we're just actively for other types of apps:

CopperheadOS/platform_frameworks_base@fb71057

Eventually, Google will ship this for normal apps too. They're doing it for instant apps already.

@thestinger thestinger closed this Oct 12, 2017

@vanitasvitae

This comment has been minimized.

Show comment Hide comment
@vanitasvitae

vanitasvitae Oct 12, 2017

Just for documentation: enabling background access to clipboard does NOT solve the issue for me.

Just for documentation: enabling background access to clipboard does NOT solve the issue for me.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 12, 2017

Contributor

So it's not a compatibility issue tied to CopperheadOS changes.

Contributor

thestinger commented Oct 12, 2017

So it's not a compatibility issue tied to CopperheadOS changes.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 12, 2017

Contributor

They closed the issue simply because you stated it occurred on CopperheadOS, not because they have any actual reason to think it's tied to CopperheadOS. This isn't the right place to file a K9 issue. You'll need to replicate the same scenario on stock Android and file it again with them if that's all they want to support. I recommend using adb backup and adb restore to move the app over to a different device on stock 8.0.0.

Contributor

thestinger commented Oct 12, 2017

They closed the issue simply because you stated it occurred on CopperheadOS, not because they have any actual reason to think it's tied to CopperheadOS. This isn't the right place to file a K9 issue. You'll need to replicate the same scenario on stock Android and file it again with them if that's all they want to support. I recommend using adb backup and adb restore to move the app over to a different device on stock 8.0.0.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 12, 2017

Contributor

Also try capturing logs with adb logcat, but really, I don't see how it could be tied to CopperheadOS. It's far more likely that you found a way to break it on 8.0.0 in general.

Contributor

thestinger commented Oct 12, 2017

Also try capturing logs with adb logcat, but really, I don't see how it could be tied to CopperheadOS. It's far more likely that you found a way to break it on 8.0.0 in general.

@xbtc-im

This comment has been minimized.

Show comment Hide comment
@xbtc-im

xbtc-im Oct 13, 2017

vanitasvitae what version of k9 mail are you using ?
i have the same issue, running k9 version v5.300. i also believe this is not a copperhead issue, but k9/oreo related. Same thing when selecting text and trying to "share" it, nothing happens.
logcat shows absolutely nothing.

xbtc-im commented Oct 13, 2017

vanitasvitae what version of k9 mail are you using ?
i have the same issue, running k9 version v5.300. i also believe this is not a copperhead issue, but k9/oreo related. Same thing when selecting text and trying to "share" it, nothing happens.
logcat shows absolutely nothing.

@xbtc-im

This comment has been minimized.

Show comment Hide comment
@xbtc-im

xbtc-im Oct 13, 2017

it's related to this bug:
#644
copy/paste/share issue also happens with Chormium , im guessing k9 uses WebView to display e-mails, so this is an inherited issue. Same with pdf viewer and everything that uses WebView.

xbtc-im commented Oct 13, 2017

it's related to this bug:
#644
copy/paste/share issue also happens with Chormium , im guessing k9 uses WebView to display e-mails, so this is an inherited issue. Same with pdf viewer and everything that uses WebView.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 13, 2017

Contributor

Just for documentation: enabling background access to clipboard does NOT solve the issue for me.

Contributor

thestinger commented Oct 13, 2017

Just for documentation: enabling background access to clipboard does NOT solve the issue for me.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 13, 2017

Contributor

When that feature denies access to the clipboard, it logs it anyway.

Contributor

thestinger commented Oct 13, 2017

When that feature denies access to the clipboard, it logs it anyway.

@xbtc-im

This comment has been minimized.

Show comment Hide comment
@xbtc-im

xbtc-im Oct 13, 2017

Same here, it has nothing to do with clipboard access permission. Copy/Paste/Share just doesn't work in Chromium and any WebView related app ...

xbtc-im commented Oct 13, 2017

Same here, it has nothing to do with clipboard access permission. Copy/Paste/Share just doesn't work in Chromium and any WebView related app ...

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 13, 2017

Contributor

That's not what #644 is filed about and if you're saying it doesn't work with share either that's a much different issue. It isn't something that I've heard about before.

Contributor

thestinger commented Oct 13, 2017

That's not what #644 is filed about and if you're saying it doesn't work with share either that's a much different issue. It isn't something that I've heard about before.

@xbtc-im

This comment has been minimized.

Show comment Hide comment
@xbtc-im

xbtc-im Oct 13, 2017

I believe it's at least related. You can copy/paste/share from the "headers" box in k9, similar to copying from the address bar in Chromium ... I might be wrong though, maybe someone else can try too ...

xbtc-im commented Oct 13, 2017

I believe it's at least related. You can copy/paste/share from the "headers" box in k9, similar to copying from the address bar in Chromium ... I might be wrong though, maybe someone else can try too ...

@xbtc-im

This comment has been minimized.

Show comment Hide comment
@xbtc-im

xbtc-im Oct 13, 2017

Can you copy text from PdfViewer ?

xbtc-im commented Oct 13, 2017

Can you copy text from PdfViewer ?

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 13, 2017

Contributor

It's not related if enabling background clipboard access doesn't resolve it. The issue (#644) is filed about the background clipboard access feature, not something else. It's not related if it's not caused by that.

Contributor

thestinger commented Oct 13, 2017

It's not related if enabling background clipboard access doesn't resolve it. The issue (#644) is filed about the background clipboard access feature, not something else. It's not related if it's not caused by that.

@xbtc-im

This comment has been minimized.

Show comment Hide comment
@xbtc-im

xbtc-im Oct 13, 2017

Can you copy text from PdfViewer ? Forget the "share" part ...
And still Chromium/WebView are the only ones that have this problem. k9 uses WebView to display the email content, i remember an older issue an user had after disabling Chromium.

xbtc-im commented Oct 13, 2017

Can you copy text from PdfViewer ? Forget the "share" part ...
And still Chromium/WebView are the only ones that have this problem. k9 uses WebView to display the email content, i remember an older issue an user had after disabling Chromium.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 13, 2017

Contributor

Yes, copying test works for me, but the issue makes sense to me now and could be a Chromium bug that will be resolved by v63. v60 and v61 didn't have support for Oreo open sourced and it's in a weird situation right now, although I wouldn't expect that to impact Chromium only the WebView.

Contributor

thestinger commented Oct 13, 2017

Yes, copying test works for me, but the issue makes sense to me now and could be a Chromium bug that will be resolved by v63. v60 and v61 didn't have support for Oreo open sourced and it's in a weird situation right now, although I wouldn't expect that to impact Chromium only the WebView.

@xbtc-im

This comment has been minimized.

Show comment Hide comment
@xbtc-im

xbtc-im Oct 13, 2017

Yes, if i remember correctly, this started since Oreo ...

xbtc-im commented Oct 13, 2017

Yes, if i remember correctly, this started since Oreo ...

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 13, 2017

Contributor

And to clarify something "upstream-app" in this case applies to Chromium.

Contributor

thestinger commented Oct 13, 2017

And to clarify something "upstream-app" in this case applies to Chromium.

@xbtc-im

This comment has been minimized.

Show comment Hide comment
@xbtc-im

xbtc-im Oct 13, 2017

Did you test other WebView apps ?

xbtc-im commented Oct 13, 2017

Did you test other WebView apps ?

@vanitasvitae

This comment has been minimized.

Show comment Hide comment
@vanitasvitae

vanitasvitae Oct 13, 2017

Bug does not appear on k9 on LineageOS 15.

Bug does not appear on k9 on LineageOS 15.

@xbtc-im

This comment has been minimized.

Show comment Hide comment
@xbtc-im

xbtc-im Oct 13, 2017

@vanitasvitae can you also test other webview related apps ? Also the "share" option ?
CopperheadOS uses a custom version of Chromium, that also implements WebView ... as far as i know, Lineage uses their own version of Browser/WebView ...

xbtc-im commented Oct 13, 2017

@vanitasvitae can you also test other webview related apps ? Also the "share" option ?
CopperheadOS uses a custom version of Chromium, that also implements WebView ... as far as i know, Lineage uses their own version of Browser/WebView ...

@xbtc-im

This comment has been minimized.

Show comment Hide comment
@xbtc-im

xbtc-im Oct 13, 2017

Probably the bug does not appear on standard AOSP either

xbtc-im commented Oct 13, 2017

Probably the bug does not appear on standard AOSP either

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 13, 2017

Contributor

as far as i know, Lineage uses their own version of Browser/WebView ...

No, they use Google's WebView build. I explained this already:

Yes, copying test works for me, but the issue makes sense to me now and could be a Chromium bug that will be resolved by v63. v60 and v61 didn't have support for Oreo open sourced and it's in a weird situation right now, although I wouldn't expect that to impact Chromium only the WebView.

and

And to clarify something "upstream-app" in this case applies to Chromium.

Contributor

thestinger commented Oct 13, 2017

as far as i know, Lineage uses their own version of Browser/WebView ...

No, they use Google's WebView build. I explained this already:

Yes, copying test works for me, but the issue makes sense to me now and could be a Chromium bug that will be resolved by v63. v60 and v61 didn't have support for Oreo open sourced and it's in a weird situation right now, although I wouldn't expect that to impact Chromium only the WebView.

and

And to clarify something "upstream-app" in this case applies to Chromium.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 13, 2017

Contributor

@xbtc-im AOSP doesn't have a current release of the WebView. It has a build of Chromium v58 from their internal tree with code that wasn't open sourced:

https://android.googlesource.com/platform/external/chromium-webview/+log/daaab59ab71941fbdbeb0403f01e851bb2ff56c8

Contributor

thestinger commented Oct 13, 2017

@xbtc-im AOSP doesn't have a current release of the WebView. It has a build of Chromium v58 from their internal tree with code that wasn't open sourced:

https://android.googlesource.com/platform/external/chromium-webview/+log/daaab59ab71941fbdbeb0403f01e851bb2ff56c8

@xbtc-im

This comment has been minimized.

Show comment Hide comment
@xbtc-im

xbtc-im Oct 13, 2017

Thanks for the clarification. Basically we should wait for the next Chromium release , right ?

xbtc-im commented Oct 13, 2017

Thanks for the clarification. Basically we should wait for the next Chromium release , right ?

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 13, 2017

Contributor

I stated that it's likely an issue with Chromium caused by the code not being fully open sourced. I said that above before this discussion. I didn't say I was certain that was the issue.

Anyway, I'm not finding this thread to be useful.

Contributor

thestinger commented Oct 13, 2017

I stated that it's likely an issue with Chromium caused by the code not being fully open sourced. I said that above before this discussion. I didn't say I was certain that was the issue.

Anyway, I'm not finding this thread to be useful.

@thestinger thestinger closed this Oct 13, 2017

@thestinger thestinger locked and limited conversation to collaborators Oct 13, 2017

@thestinger thestinger deleted a comment from xbtc-im Oct 13, 2017

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 13, 2017

Contributor

#767 is the new issue tracking this problem. This thread isn't productive.

Contributor

thestinger commented Oct 13, 2017

#767 is the new issue tracking this problem. This thread isn't productive.

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 21, 2017

Contributor

This is fixed in Chromium 62 which is in the latest CopperheadOS release for today.

Contributor

thestinger commented Oct 21, 2017

This is fixed in Chromium 62 which is in the latest CopperheadOS release for today.

@thestinger thestinger unlocked this conversation Oct 21, 2017

@vanitasvitae

This comment has been minimized.

Show comment Hide comment
@vanitasvitae

vanitasvitae Oct 21, 2017

I can conform that the issue is resolved. Great :)

I can conform that the issue is resolved. Great :)

@thestinger

This comment has been minimized.

Show comment Hide comment
@thestinger

thestinger Oct 21, 2017

Contributor

It was probably caused by Google's botched release of the Chromium sources. v60 and v61 didn't have full Oreo support and we had to deal with that downstream, which apparently wasn't complete.

Contributor

thestinger commented Oct 21, 2017

It was probably caused by Google's botched release of the Chromium sources. v60 and v61 didn't have full Oreo support and we had to deal with that downstream, which apparently wasn't complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment