Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
CarrierConfig vendor.xml for Pixel 2 (XL) #826
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Apr 4, 2018
Contributor
It seems they might have stopped using this and moved to the protobuf files, without code in AOSP to handle them.
|
It seems they might have stopped using this and moved to the protobuf files, without code in AOSP to handle them. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
xbtc-im
Apr 4, 2018
What's this with the CarrierConfig anyway ? Wasn't the SIM card supposed to handle all that ?
xbtc-im
commented
Apr 4, 2018
|
What's this with the CarrierConfig anyway ? Wasn't the SIM card supposed to handle all that ? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Apr 4, 2018
Contributor
Well, it doesn't, there's a massive database of default APNs and the right one is picked based on ids from the SIM card. If there isn't an entry, you need to manually enter an APN for working SMS/MMS and data. This CarrierConfig stuff is needed for some things outside the scope of APN configuration.
|
Well, it doesn't, there's a massive database of default APNs and the right one is picked based on ids from the SIM card. If there isn't an entry, you need to manually enter an APN for working SMS/MMS and data. This CarrierConfig stuff is needed for some things outside the scope of APN configuration. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
xbtc-im
Apr 4, 2018
Yes, but besides the APN-s there are other issues ? For me there is no issue manually editing the APN settings for the internet, those can easily be looked up anyway ... And does anyone still use MMS ? :)
xbtc-im
commented
Apr 4, 2018
|
Yes, but besides the APN-s there are other issues ? For me there is no issue manually editing the APN settings for the internet, those can easily be looked up anyway ... And does anyone still use MMS ? :) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Apr 4, 2018
Contributor
Yes, there are other issues, but it mostly works fine with just the standard APN database otherwise we wouldn't have launched Pixel 2 (XL) support. We only do this on the Pixel and Pixel XL, never did it on the Nexus 5X and 6P.
|
Yes, there are other issues, but it mostly works fine with just the standard APN database otherwise we wouldn't have launched Pixel 2 (XL) support. We only do this on the Pixel and Pixel XL, never did it on the Nexus 5X and 6P. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
xbtc-im
Apr 4, 2018
As an edit for my previous post: As i see it, MMS is an useless feature, that only adds unnecessary attack surface to the *G standards... It should totally be removed.
So without the CarrierConfig, the phone will not be useless, you just need to do a bit of work when you swap sim cards ?
xbtc-im
commented
Apr 4, 2018
|
As an edit for my previous post: As i see it, MMS is an useless feature, that only adds unnecessary attack surface to the *G standards... It should totally be removed. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
No, that's not what I said at all. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Apr 4, 2018
Contributor
Well, it doesn't, there's a massive database of default APNs and the right one is picked based on ids from the SIM card. If there isn't an entry, you need to manually enter an APN for working SMS/MMS and data. This CarrierConfig stuff is needed for some things outside the scope of APN configuration.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Apr 4, 2018
Contributor
outside the scope of APN configuration.
i.e. nothing to do with basic mobile data and MMS
i.e. nothing to do with basic mobile data and MMS |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
xbtc-im
commented
Apr 4, 2018
|
Yes, sorry about that. There are a lot of other settings too ... Missed that. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
Look at what's in the one we ship for the Pixel / Pixel XL. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
xbtc-im
Apr 4, 2018
Off topic, i wonder what the software in the radio partition is capable of ... AFAIK that's a RTOS handling all the network/radio stuff, i wonder how much access does it have to the main memory / cpu.
xbtc-im
commented
Apr 4, 2018
|
Off topic, i wonder what the software in the radio partition is capable of ... AFAIK that's a RTOS handling all the network/radio stuff, i wonder how much access does it have to the main memory / cpu. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Apr 4, 2018
Contributor
Components like the cellular radio, GPU, media decode/encode engine, etc. are contained by IOMMUs.
|
Components like the cellular radio, GPU, media decode/encode engine, etc. are contained by IOMMUs. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
thestinger
Apr 4, 2018
Contributor
PCIe peripherals may or may not be contained well. You would need to do research more specific to devices. Most of these kinds of components are part of the SoC and the IOMMU configuration is reused across all the devices using the SoC unless they do something very strange.
There's a higher chance of a component separate from the SoC not being properly isolated. A component being on the SoC or having access to memory doesn't mean it isn't contained and likewise a component not being on the SoC doesn't mean it is contained.
|
PCIe peripherals may or may not be contained well. You would need to do research more specific to devices. Most of these kinds of components are part of the SoC and the IOMMU configuration is reused across all the devices using the SoC unless they do something very strange. There's a higher chance of a component separate from the SoC not being properly isolated. A component being on the SoC or having access to memory doesn't mean it isn't contained and likewise a component not being on the SoC doesn't mean it is contained. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
xbtc-im
commented
Apr 4, 2018
|
Thanks for the clarification |
thestinger commentedJan 14, 2018
No description provided.