Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permanent inventory update issues #49

Closed
Graznop opened this issue Jul 1, 2021 · 1 comment · Fixed by #48
Closed

Permanent inventory update issues #49

Graznop opened this issue Jul 1, 2021 · 1 comment · Fixed by #48

Comments

@Graznop
Copy link

Graznop commented Jul 1, 2021

A few issues with the curses permanent inventory:

  • when carrying capacity changes (e.g. recovery from Xan bite), capacity is not updated
  • when declining to buy something via 'Itemized billing', item's unpaid status incorrectly updates
@Graznop
Copy link
Author

Graznop commented Jul 1, 2021

Looks like the itemised billing issue is in vanilla (3.6.6). With multiple unpaid items, paying for one of them clears the unpaid status of the others in perminvent.

@entrez entrez mentioned this issue Jul 1, 2021
Closed
entrez added a commit to entrez/xNetHack that referenced this issue Jul 1, 2021
@entrez
Fix copperwater#49: perm_invent carry capacity
09f20b8 
Ensure carry capacity is updated in the perm_invent pane when the
factors that define it change (e.g. leg injury, exercise or abuse,
etc).  The other problem mentioned in the issue, one related to item
price display and itemized billing with perm_invent, is a vanilla bug.

Closes copperwater#49.
@entrez entrez mentioned this issue Jul 1, 2021
Merged
entrez added a commit to entrez/xNetHack that referenced this issue Jul 1, 2021
@entrez
Fix copperwater#49: perm_invent carry capacity
34148d4 
Ensure carry capacity is updated in the perm_invent pane when the
factors that define it change (e.g. leg injury, exercise or abuse,
etc).  The other problem mentioned in the issue, one related to item
price display and itemized billing with perm_invent, is a vanilla bug.

Closes copperwater#49.
copperwater pushed a commit that referenced this issue Jul 5, 2021
@entrez @copperwater
Fix #49: perm_invent carry capacity
81cd0c0 
Ensure carry capacity is updated in the perm_invent pane when the
factors that define it change (e.g. leg injury, exercise or abuse,
etc).  The other problem mentioned in the issue, one related to item
price display and itemized billing with perm_invent, is a vanilla bug.

Closes #49.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

a few small repairs entrez/xNetHack
1 participant
@Graznop